Work around WP data handling failure

Author: rmccue

lib/class-wp-json-users.php

@@ -223,24 +223,22 @@ public function add_comment_author_data( $data, $comment, $context ) {
 	}
 
 	protected function insert_user( $data ) {
+		$user = new stdClass;
+
 		if ( ! empty( $data['ID'] ) ) {
-			$user = get_userdata( $data['ID'] );
+			$existing = get_userdata( $data['ID'] );
 
-			if ( ! $user ) {
+			if ( ! $existing ) {
 				return new WP_Error( 'json_user_invalid_id', __( 'Invalid user ID.' ), array( 'status' => 404 ) );
 			}
 
 			if ( ! current_user_can( 'edit_user', $data['ID'] ) ) {
 				return new WP_Error( 'json_user_cannot_edit', __( 'Sorry, you are not allowed to edit this user.' ), array( 'status' => 403 ) );
 			}
 
+			$user->ID = $existing->ID;
 			$update = true;
 		} else {
-			$user = new WP_User();
-
-			// Workaround for https://core.trac.wordpress.org/ticket/28019
-			$user->data = new stdClass;
-
 			if ( ! current_user_can( 'create_users' ) ) {
 				return new WP_Error( 'json_cannot_create', __( 'Sorry, you are not allowed to create users.' ), array( 'status' => 403 ) );
 			}