always ensure the file extension maps to something that is registered with the browser

davecheney · davecheney · commit 2bed431dc481 · 2014-07-10T18:18:01.000+10:00
diff --git a/browser.go b/browser.go
@@ -35,7 +35,12 @@ func OpenReader(r io.Reader) error {
 	if err := f.Close(); err != nil {
 		return fmt.Errorf("browser: caching temporary file failed: %v", err)
 	}
-	return OpenFile(f.Name())
+	oldname := f.Name()
+	newname := oldname + ".html"
+	if err := os.Rename(oldname, newname); err != nil {
+		return fmt.Errorf("browser: renaming temporary file failed: %v", err)
+	}
+	return OpenFile(newname)
 }
 
 // OpenURL opens a new browser window pointing to url.

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,12 @@ func OpenReader(r io.Reader) error {`
`35`	`35`	`if err := f.Close(); err != nil {`
`36`	`36`	`return fmt.Errorf("browser: caching temporary file failed: %v", err)`
`37`	`37`	`}`
`38`		`- return OpenFile(f.Name())`
	`38`	`+ oldname := f.Name()`
	`39`	`+ newname := oldname + ".html"`
	`40`	`+ if err := os.Rename(oldname, newname); err != nil {`
	`41`	`+ return fmt.Errorf("browser: renaming temporary file failed: %v", err)`
	`42`	`+ }`
	`43`	`+ return OpenFile(newname)`
`39`	`44`	`}`
`40`	`45`
`41`	`46`	`// OpenURL opens a new browser window pointing to url.`