Fix running project on Windows (#29)

* Allow running project on Windows

* Un-export Window-specific identifiers

* Remove obsolete `setFlags`

Author: mislav

browser.go

@@ -58,6 +58,5 @@ func runCmd(prog string, args ...string) error {
 	cmd := exec.Command(prog, args...)
 	cmd.Stdout = Stdout
 	cmd.Stderr = Stderr
-	setFlags(cmd)
 	return cmd.Run()
 }

browser_darwin.go

@@ -5,5 +5,3 @@ import "os/exec"
 func openBrowser(url string) error {
 	return runCmd("open", url)
 }
-
-func setFlags(cmd *exec.Cmd) {}

browser_freebsd.go

@@ -12,5 +12,3 @@ func openBrowser(url string) error {
 	}
 	return err
 }
-
-func setFlags(cmd *exec.Cmd) {}

browser_linux.go

@@ -19,5 +19,3 @@ func openBrowser(url string) error {
 
 	return &exec.Error{Name: strings.Join(providers, ","), Err: exec.ErrNotFound}
 }
-
-func setFlags(cmd *exec.Cmd) {}

browser_openbsd.go

@@ -12,5 +12,3 @@ func openBrowser(url string) error {
 	}
 	return err
 }
-
-func setFlags(cmd *exec.Cmd) {}

browser_unsupported.go

@@ -11,5 +11,3 @@ import (
 func openBrowser(url string) error {
 	return fmt.Errorf("openBrowser: unsupported operating system: %v", runtime.GOOS)
 }
-
-func setFlags(cmd *exec.Cmd) {}

browser_windows.go

@@ -1,13 +1,11 @@
 //go:generate mkwinsyscall -output zbrowser_windows.go browser_windows.go
-//sys ShellExecute(hwnd int, verb string, file string, args string, cwd string, showCmd int) (err error) = shell32.ShellExecuteW
+//sys shellExecute(hwnd int, verb string, file string, args string, cwd string, showCmd int) (err error) = shell32.ShellExecuteW
 package browser
 
 import "os/exec"
-const SW_SHOWNORMAL = 1
 
-func openBrowser(url string) error {
-   return ShellExecute(0, "", url, "", "", SW_SHOWNORMAL)
-}
+const sW_SHOWNORMAL = 1
 
-func setFlags(cmd *exec.Cmd) {
+func openBrowser(url string) error {
+	return shellExecute(0, "", url, "", "", sW_SHOWNORMAL)
 }

go.mod

@@ -1,3 +1,5 @@
 module github.com/pkg/browser
 
 go 1.14
+
+require golang.org/x/sys v0.0.0-20210319071255-635bc2c9138d // indirect