Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a v1.0.0 #38

Open
dominykas opened this issue Jan 16, 2022 · 10 comments
Open

Release a v1.0.0 #38

dominykas opened this issue Jan 16, 2022 · 10 comments

Comments

@dominykas
Copy link
Member

dominykas commented Jan 16, 2022

If there's no objections, I'm going to tag a v1.0.0 next week?

I'll also move a v1 tag there and update all the @main references to @v1.

I intend to just use npm version for the time being to bump versions, and a small workflow to automatically move the major tag forward whenever there's a new tag on HEAD (main).

@ljharb
Copy link
Member

ljharb commented Jan 16, 2022

How many things are using this so far? it seems like usage should be somewhat extensive before we’re sure it’s ready for v1.

@dominykas
Copy link
Member Author

dominykas commented Jan 16, 2022

At the same time, people don't want to use it, because it's @main :)

From the API perspective, the surface is small enough to hopefully not require breaking changes immediately?

@ljharb
Copy link
Member

ljharb commented Jan 16, 2022

We could release a v0.1.0 tag, at least?

@dominykas
Copy link
Member Author

dominykas commented Jan 17, 2022

So from a perspective of someone using it, they'd start at @v0 and have to expect breaking changes (or start at @v0.1 and fiddle with updates) - which is not much different than @main.

@ljharb
Copy link
Member

ljharb commented Jan 17, 2022

v0.1.0 to v0.1.1 has no breaking changes, only v0.2 or higher would have breaking changes.

@dominykas
Copy link
Member Author

dominykas commented Jan 18, 2022

Semver does not prescribe that (i.e. neither does it prescribe that you must bump minor when there's breaking changes, nor that you shouldn't bump minor when there aren't any) - anything goes in pre-v1.

Updated #39 to set a vX.Y when a vX.Y.Z is pushed.

Will poke around to see what people think about using this at @v0.1.

@ljharb
Copy link
Member

ljharb commented Jan 18, 2022

semver v1 does, as does npm’s semver module which is really the arbiter here given the intended market

In vX.Y.Z, and v0.X.Y, and v0.0.X, X is the major, Y the minor, and Z the patch.

@dominykas
Copy link
Member Author

dominykas commented Jan 31, 2022

Released a v0.1.0. The v0 and v0.1 tags got created automatically.

Opened a #40 until there's better automation (or until we split off the private actions into separate repos) - we don't want to keep the @main as it could potentially break things for people importing the action at an older tag.

@wesleytodd
Copy link
Member

It looks like this has not happened yet? I was wondering if before we did this would you be open to me making a few changes to expand the feature set of this package a bit more? I have been working on a few workflows which support more and I would love to make those OSS. Just been a while since I have engaged in here and want to make sure we would be aligned on the direction before committing to the work.

@dominykas
Copy link
Member Author

Sure, I'm all for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants