Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for R-to-L translation #96

Open
israelcefrin opened this issue Nov 18, 2021 · 0 comments
Open

Missing support for R-to-L translation #96

israelcefrin opened this issue Nov 18, 2021 · 0 comments

Comments

@israelcefrin
Copy link

Describe the bug
When a Journal uses a locale for languages that are R-to-L read, e.g. ar-IQ, the theme doesn't change the text direction.

To Reproduce
Steps to reproduce the behavior:

  1. Enable ar-IQ or any R-to-L locale
  2. Go to the public interface
  3. Click on the locale that was installed and enabled
  4. See error

Expected behavior
It is expected that all text content changes the reading direction.

Screenshots

Desktop (please complete the following information):

  • OS: any
  • Browser : any

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser : any

Additional context
I've added a workaround in this journal: https://jmlph.net/index.php/jmlph, including an IF/ELSE to inject dir="rtl" class="rtl" in the HTML tag. However, it is required to check every R-to-L language and, maybe, create an array for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant