#11833 Refactor GET /editTaskTemplates to use Template scopes and camelCase params

Author: Hafsa-Naeem

api/v1/editTaskTemplates/PKPEditTaskTemplateController.php

@@ -66,27 +66,43 @@ public function getMany(Request $request): JsonResponse
     {
         $context = $this->getRequest()->getContext();
 
-        $q = Template::query()
-            ->byContextId((int) $context->getId())
+        // Start with our standard collector/scopes
+        $collector = Template::byContextId((int) $context->getId())
             ->with('userGroups');
 
-        if ($request->filled('stageId')) {
-            $q->where('stage_id', (int) $request->query('stageId'));
-        }
+        // Apply supported filters from query params via model scopes
+        foreach ($request->query() as $param => $val) {
+            switch ($param) {
+                case 'stageId':
+                    if ($val !== null && $val !== '') {
+                        $collector = $collector->withStageId((int) $val);
+                    }
+                    break;
+
+                case 'include':
+                    // Accept "true"/"false", 1/0, etc.
+                    $bool = filter_var($val, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
+                    if ($bool !== null) {
+                        $collector = $collector->withInclude($bool);
+                    }
+                    break;
 
-        if ($request->has('include')) {
-            $include = filter_var($request->query('include'), FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
-            if ($include !== null) {
-                $q->where('include', $include);
+                case 'emailTemplateKey':
+                    $key = trim((string) $val);
+                    if ($key !== '') {
+                        $collector = $collector->withEmailTemplateKey($key);
+                    }
+                    break;
+
+                // ignore unknown params
             }
         }
 
-        if ($request->filled('emailTemplateKey')) {
-            $q->where('email_template_key', trim((string) $request->query('emailTemplateKey')));
-        }
-        $collection = $q->orderByPkDesc()->get();
+        $collection = $collector->orderByPkDesc()->get();
+
         return EditTaskTemplateResource::collection($collection)
             ->response()
             ->setStatusCode(Response::HTTP_OK);
-     }
+    }
+
 }