Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register constants in Smarty #10243

Open
jonasraoni opened this issue Jul 23, 2024 · 1 comment
Open

Register constants in Smarty #10243

jonasraoni opened this issue Jul 23, 2024 · 1 comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone

Comments

@jonasraoni
Copy link
Contributor

Describe the bug
A couple of constants are emitting the message Using unregistered static method "{$constant}" in a template is deprecated and will be removed in a future release. Use Smarty::registerClass to explicitly register a class for access.

Here's the current list:

PKP\components\forms\context\PKPThemeForm::FORM_THEME
PKP\components\forms\context\PKPRestrictBulkEmailsForm::FORM_RESTRICT_BULK_EMAILS
PKP\components\forms\publication\TitleAbstractForm::FORM_TITLE_ABSTRACT
PKP\components\forms\publication\PKPCitationsForm::FORM_CITATIONS
APP\components\forms\publication\SubmissionPaymentsForm::FORM_SUBMISSION_PAYMENTS
PKP\components\forms\publication\PKPMetadataForm::FORM_METADATA
PKP\components\forms\publication\PKPPublicationIdentifiersForm::FORM_PUBLICATION_IDENTIFIERS
\PKP\submissionFile\SubmissionFile::SUBMISSION_FILE_PROOF
APP\components\forms\publication\AssignToIssueForm::FORM_ASSIGN_TO_ISSUE
\APP\journal\Journal::PUBLISHING_MODE_SUBSCRIPTION

What application are you using?
OJS 3.5

@jonasraoni jonasraoni added Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. Try Me This issue might be good for a new contributor. Can you help us? labels Jul 23, 2024
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Jul 23, 2024
@asmecher
Copy link
Member

asmecher commented Jul 23, 2024

I'm hoping this will go away before 3.5.0 gets released -- see smarty-php/smarty#1028. (In other words, please don't work on this yet!)

@asmecher asmecher removed the Try Me This issue might be good for a new contributor. Can you help us? label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Development

No branches or pull requests

2 participants