Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS] Review reminder are sent even for closed rounds #10568

Open
forgive38 opened this issue Oct 29, 2024 · 2 comments
Open

[OJS] Review reminder are sent even for closed rounds #10568

forgive38 opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
Try Me This issue might be good for a new contributor. Can you help us?

Comments

@forgive38
Copy link
Contributor

Describe the bug
I think that if a new round has been initiated, no reminder should be sent for previous review requests?
(I think this has already been discussed, but I can't find where).

Thanks

What application are you using?
OJS 3.4 (i think it is the same for main)

@asmecher asmecher added the Try Me This issue might be good for a new contributor. Can you help us? label Oct 29, 2024
@defstat
Copy link
Contributor

defstat commented Nov 6, 2024

@forgive38 thanks for reporting that. Could you add the steps to reproduce the issue?

@defstat defstat self-assigned this Nov 6, 2024
@forgive38
Copy link
Contributor Author

Follow the steps below:

  • create a submission
  • push submission to review stage
  • add reviewers with due dates such as 2024-11-20
  • create a new review round (with other reviewers with different due dates such as 2024-12-01...)

then wait ... (or change the dates to test! ) until the task ReviewReminder is triggered - if the 'numDaysBeforeInviteReminder' parameters are set to 1 - it will be 2024-11-21 and a reminder will be sent for review assignments of the first round

I hope that's clear...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Development

No branches or pull requests

3 participants