Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Log should include file deletions #10814

Open
pmangahis opened this issue Jan 16, 2025 · 2 comments
Open

Activity Log should include file deletions #10814

pmangahis opened this issue Jan 16, 2025 · 2 comments
Assignees
Labels
Bug:2:Major A bug found in common paths that reduces functionality for a large number of users Try Me This issue might be good for a new contributor. Can you help us?
Milestone

Comments

@pmangahis
Copy link

Describe the bug
The Activity log shows information when files have been uploaded and edited. However, when files get deleted, there is no record anywhere.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the manuscript
  2. Click on Activity log

What application are you using?
OJS, OMP or OPS version 3.x and onwards

Additional information
This leads to “Where’s this file that was uploaded?” situations, making it difficult for editors to investigate missing files. It also requires access to the logs, which not all OJS users might have.

This often requires systems-level intervention and combing through logs to determine what occurred.

@asmecher asmecher added Try Me This issue might be good for a new contributor. Can you help us? Bug:2:Major A bug found in common paths that reduces functionality for a large number of users labels Jan 17, 2025
@asmecher asmecher added this to the 3.5.0-x milestone Jan 17, 2025
@kaitlinnewson kaitlinnewson changed the title Activity Log should not include file deletions Activity Log should include file deletions Jan 17, 2025
@taslangraham taslangraham self-assigned this Feb 24, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Feb 25, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Feb 25, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Feb 25, 2025
@taslangraham
Copy link
Contributor

Ready for review. @kaitlinnewson @jonasraoni Do you mind taking a look, please?

PRs
pkp-lib stable 3.3
pkp-lib stable-3.4
pkp-lib 3.5/main

Submodule updates (stable branches only)
ojs 3.3
omp 3.3
ops 3.3

ops 3.4
ojs 3.4
omp 3.4

@kaitlinnewson
Copy link
Member

Looks good, all approved! I guess we are logging the deletion twice here, but I think it makes sense since the file log can't be accessed once the file is removed.

taslangraham added a commit that referenced this issue Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Major A bug found in common paths that reduces functionality for a large number of users Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Development

No branches or pull requests

4 participants