Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the SectionService to the new Repository/DAO/Map pattern #7128

Closed
6 tasks
NateWr opened this issue Jun 15, 2021 · 3 comments
Closed
6 tasks

Convert the SectionService to the new Repository/DAO/Map pattern #7128

NateWr opened this issue Jun 15, 2021 · 3 comments
Assignees
@bozana @pkp-dev-infrastructure
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.4.0-0

Comments

@NateWr
Copy link
Contributor

NateWr commented Jun 15, 2021 •
edited by bozana
Loading

The section entity needs to be converted to use the new pattern for DAOs, Maps and Repositories introduced in #5328. This requires the following:

  • Convert the DAO to extend EntityDAO and use type hints.
  • Convert the SectionService to a repository .
  • Adapt the schema for add/edit operations and add methods to add/edit/delete users to the DAO/Repository.
  • Convert SectionService::getProperties() to a Map that extends PKP\core\maps\SchemaMap.
  • Add any necessary methods to SectionService so that direct access to the DAO is not required.
  • Refactor existing uses of DAORegistry::getDAO('SectionDAO') to use the repository instead.

PRs:

Further PRs:
@NateWr NateWr added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Jun 15, 2021
@NateWr NateWr added this to the OJS/OMP/OPS 3.4 milestone Jun 15, 2021
ewhanson added a commit to ewhanson/citationStyleLanguage that referenced this issue Jul 20, 2021
@ewhanson
WIP: pkp/pkp-lib#7128 Issue EntityDAO refactor
9423dd5
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 2, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
1462348 
…tern
bozana added a commit to bozana/ops that referenced this issue Feb 2, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
f43f6e6 
…/Map pattern
bozana added a commit to bozana/ops that referenced this issue Feb 2, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
3998c88
bozana added a commit to bozana/omp that referenced this issue Feb 2, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
3725523 
…/Map pattern
bozana added a commit to bozana/omp that referenced this issue Feb 2, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
72222df
bozana added a commit to bozana/ojs that referenced this issue Feb 2, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
782f05e 
…/Map pattern
bozana added a commit to bozana/ojs that referenced this issue Feb 2, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
294c497
This was referenced Feb 2, 2023
Merged
Merged
Merged
Merged
@bozana
Copy link
Collaborator

bozana commented Feb 2, 2023

@NateWr, could you please review the PRs above?

bozana added a commit to bozana/omp that referenced this issue Feb 6, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
5081c22 
…/Map pattern
bozana added a commit to bozana/ojs that referenced this issue Feb 6, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
0b35455 
…/Map pattern
@NateWr
Copy link
Contributor Author

NateWr commented Feb 6, 2023

Looks good @bozana! I've left a few comments with possible bugs, but it's mostly stylistic suggestions. Go ahead and merge once you're happy with it. 👍

bozana added a commit to bozana/pkp-lib that referenced this issue Feb 7, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
1666b42 
…tern -- changes after review
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 7, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
18d8030 
…tern
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 7, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
80852d8 
…tern -- changes after review
bozana added a commit to bozana/ojs that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
7f6cbe7 
…/Map pattern
bozana added a commit to bozana/ojs that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
ce59f1e 
…/Map pattern - changes after review
bozana added a commit to bozana/ojs that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
af292b1
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 7, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
98a04d6 
…tern -- changes after review
bozana added a commit to bozana/ojs that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
f56b6e0
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 7, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
eabdd58 
…tern -- changes after review
bozana added a commit to bozana/omp that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
174ca2d 
…/Map pattern
bozana added a commit to bozana/omp that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
22e1bb6
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 7, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
e869389 
…tern -- changes after review
bozana added a commit to bozana/ojs that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
ce30197
bozana added a commit to bozana/omp that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
63c442f
bozana added a commit to bozana/ops that referenced this issue Feb 7, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
5945a9e
bozana added a commit to bozana/ojs that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
712bf14 
…/Map pattern - changes after review
bozana added a commit to bozana/ojs that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
c549660
bozana added a commit to bozana/omp that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
d33da0a
bozana added a commit to bozana/ops that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
76451f8
bozana added a commit to bozana/pkp-lib that referenced this issue Feb 8, 2023
@bozana
pkp#7128 Convert the SectionService to the new Repository/DAO/Map pat…
a2b9193 
…tern -- changes after review
bozana added a commit to bozana/omp that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
4be4bad 
…/Map pattern
bozana added a commit to bozana/omp that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
2589cc0
bozana added a commit to bozana/ojs that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
c5b014a 
…/Map pattern
bozana added a commit to bozana/ojs that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
93375a8 
…/Map pattern - changes after review
bozana added a commit to bozana/ojs that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
3089ab7
bozana added a commit to bozana/ops that referenced this issue Feb 8, 2023
@bozana
pkp/pkp-lib#7128 submodule update ##bozana/7128##
9a3097b
bozana added a commit that referenced this issue Feb 8, 2023
@bozana
Merge pull request #8604 from bozana/7128
afaa8f1 
#7128 Convert the SectionService to the new Repository/DAO/Map pattern
bozana added a commit to pkp/ojs that referenced this issue Feb 8, 2023
@bozana
Merge pull request #3741 from bozana/7128
5639811 
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO/Map pattern
bozana added a commit to pkp/omp that referenced this issue Feb 8, 2023
@bozana
Merge pull request #1319 from bozana/7128
ca59f05 
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO/Map pattern
bozana added a commit to pkp/ops that referenced this issue Feb 8, 2023
@bozana
Merge pull request #455 from bozana/7128
5c54304 
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO/Map pattern
@bozana
Copy link
Collaborator

bozana commented Feb 8, 2023

Thanks a lot @NateWr!

@bozana bozana closed this as completed Feb 8, 2023
@asmecher asmecher mentioned this issue Feb 18, 2023
Closed
17 tasks
bozana added a commit to bozana/quickSubmit that referenced this issue Feb 20, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
72924e3 
…/Map pattern
bozana added a commit to bozana/ojs that referenced this issue Feb 20, 2023
@bozana
pkp/pkp-lib#7128 fix customSectionOrdering
346692e
This was referenced Feb 20, 2023
Merged
Merged
asmecher pushed a commit to pkp/ojs that referenced this issue Feb 20, 2023
@bozana @asmecher
pkp/pkp-lib#7128 fix customSectionOrdering
bddeb94
asmecher pushed a commit to pkp/quickSubmit that referenced this issue Feb 20, 2023
@bozana
pkp/pkp-lib#7128 Convert the SectionService to the new Repository/DAO…
13a0c73 
…/Map pattern (#69)
@touhidurabir touhidurabir mentioned this issue Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.4.0-0
Development

No branches or pull requests
3 participants
@bozana @NateWr @pkp-dev-infrastructure