pkp/pkp-lib#9295 introduced publication status consts similar to submission

touhidurabir · touhidurabir · commit 98ddbef48243 · 2025-08-28T17:49:39.000+06:00
diff --git a/public/globals.js b/public/globals.js
@@ -100,6 +100,10 @@ window.pkp = {
 		STATUS_PUBLISHED: 3,
 		STATUS_DECLINED: 4,
 		STATUS_SCHEDULED: 5,
+		PUBLICATION_STATUS_QUEUED: 1,
+		PUBLICATION_STATUS_PUBLISHED: 3,
+		PUBLICATION_STATUS_DECLINED: 4,
+		PUBLICATION_STATUS_SCHEDULED: 5,
 		WORKFLOW_STAGE_ID_SUBMISSION: 1,
 		WORKFLOW_STAGE_ID_INTERNAL_REVIEW: 2,
 		WORKFLOW_STAGE_ID_EXTERNAL_REVIEW: 3,
diff --git a/src/components/Form/fields/FieldSelectIssue.vue b/src/components/Form/fields/FieldSelectIssue.vue
@@ -76,7 +76,7 @@ export default {
 			type: String,
 			required: true,
 		},
-		/** One of the `PKPSubmission::STATUS_` constants. When set to `PKPSubmission::STATUS_QUEUED` or `PKPSubmission::STATUS_PUBLISHED` the issue selection will be hidden. */
+		/** One of the `PKPPublication::STATUS_` constants. When set to `PKPPublication::STATUS_QUEUED` or `PKPPublication::STATUS_PUBLISHED` the issue selection will be hidden. */
 		publicationStatus: {
 			type: Number,
 			required: true,
@@ -113,7 +113,7 @@ export default {
 		 */
 		button() {
 			let button = null;
-			if (this.publicationStatus !== pkp.const.STATUS_PUBLISHED) {
+			if (this.publicationStatus !== pkp.const.PUBLICATION_STATUS_PUBLISHED) {
 				button = {
 					label: this.value ? this.changeIssueLabel : this.assignLabel,
 				};
@@ -129,9 +129,11 @@ export default {
 		 */
 		notice() {
 			let notice = '';
-			if (this.publicationStatus === pkp.const.STATUS_PUBLISHED) {
+			if (this.publicationStatus === pkp.const.PUBLICATION_STATUS_PUBLISHED) {
 				notice = this.publishedNoticeBase;
-			} else if (this.publicationStatus === pkp.const.STATUS_SCHEDULED) {
+			} else if (
+				this.publicationStatus === pkp.const.PUBLICATION_STATUS_SCHEDULED
+			) {
 				notice = this.scheduledNoticeBase;
 			} else if (this.value) {
 				notice = this.assignedNoticeBase;
diff --git a/src/managers/GalleyManager/useGalleyManagerConfig.js b/src/managers/GalleyManager/useGalleyManagerConfig.js
@@ -85,7 +85,7 @@ export function useGalleyManagerConfig() {
 		const permittedActions = GalleyManagerConfiguration.actions
 			.filter((action) => {
 				if (
-					publication.value.status === pkp.const.STATUS_PUBLISHED &&
+					publication.value.status === pkp.const.PUBLICATION_STATUS_PUBLISHED &&
 					GalleyManagerConfiguration.actionsRequiresUnpublishedState.includes(
 						action,
 					)
@@ -141,12 +141,14 @@ export function useGalleyManagerConfig() {
 
 		if (config.permittedActions.includes(Actions.GALLEY_EDIT)) {
 			const label =
-				publication.status === pkp.const.STATUS_PUBLISHED
+				publication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
 					? t('common.view')
 					: t('common.edit');
 
 			const icon =
-				publication.status === pkp.const.STATUS_PUBLISHED ? 'View' : 'Edit';
+				publication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
+					? 'View'
+					: 'Edit';
 
 			actions.push({
 				label,
diff --git a/src/pages/workflow/components/publication/WorkflowPublicationVersionControl.vue b/src/pages/workflow/components/publication/WorkflowPublicationVersionControl.vue
@@ -31,19 +31,19 @@ const selectedPublication = computed(() =>
 const statusProps = computed(() => {
 	const publication = selectedPublication.value;
 	if (
-		publication.status === pkp.const.STATUS_QUEUED &&
+		publication.status === pkp.const.PUBLICATION_STATUS_QUEUED &&
 		publication.id === props.submission.currentPublicationId
 	) {
 		return {
 			label: t('publication.status.unscheduled'),
 			color: 'bg-stage-declined',
 		};
-	} else if (publication.status === pkp.const.STATUS_SCHEDULED) {
+	} else if (publication.status === pkp.const.PUBLICATION_STATUS_SCHEDULED) {
 		return {
 			label: t('publication.status.scheduled'),
 			color: 'bg-stage-scheduled-for-publishing',
 		};
-	} else if (publication.status === pkp.const.STATUS_PUBLISHED) {
+	} else if (publication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED) {
 		return {
 			label: t('publication.status.published'),
 			color: 'bg-stage-published',
diff --git a/src/pages/workflow/composables/useWorkflowActions.js b/src/pages/workflow/composables/useWorkflowActions.js
@@ -118,8 +118,8 @@ export function useWorkflowActions() {
 		const requirePublicationStage = isOJS()
 			? !selectedPublication.versionStage ||
 				![
-					pkp.const.STATUS_READY_TO_PUBLISH,
-					pkp.const.STATUS_READY_TO_SCHEDULE,
+					pkp.const.PUBLICATION_STATUS_READY_TO_PUBLISH,
+					pkp.const.PUBLICATION_STATUS_READY_TO_SCHEDULE,
 				].includes(selectedPublication.status)
 			: !selectedPublication.versionStage;
 
diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigAuthorOJS.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigAuthorOJS.js
@@ -274,7 +274,9 @@ export const PublicationConfig = {
 			selectedPublication,
 		}) => {
 			const items = [];
-			if (selectedPublication.status === pkp.const.STATUS_PUBLISHED) {
+			if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
+			) {
 				items.push({
 					component: 'WorkflowPublicationEditDisabled',
 					props: {},
diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js
@@ -716,7 +716,9 @@ export const PublicationConfig = {
 			selectedPublication,
 		}) => {
 			const items = [];
-			if (selectedPublication.status === pkp.const.STATUS_PUBLISHED) {
+			if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
+			) {
 				items.push({
 					component: 'WorkflowPublicationEditDisabled',
 					props: {},
@@ -769,9 +771,11 @@ export const PublicationConfig = {
 				return [];
 			}
 			if (
-				selectedPublication.status === pkp.const.STATUS_QUEUED ||
-				selectedPublication.status === pkp.const.STATUS_READY_TO_PUBLISH ||
-				selectedPublication.status === pkp.const.STATUS_READY_TO_SCHEDULE
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_QUEUED ||
+				selectedPublication.status ===
+					pkp.const.PUBLICATION_STATUS_READY_TO_PUBLISH ||
+				selectedPublication.status ===
+					pkp.const.PUBLICATION_STATUS_READY_TO_SCHEDULE
 			) {
 				if (
 					hasSubmissionPassedStage(
@@ -803,7 +807,9 @@ export const PublicationConfig = {
 							WorkflowActions.WORKFLOW_ASSIGN_TO_ISSUE_AND_SCHEDULE_FOR_PUBLICATION,
 					},
 				});
-			} else if (selectedPublication.status === pkp.const.STATUS_SCHEDULED) {
+			} else if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_SCHEDULED
+			) {
 				items.push({
 					component: 'WorkflowActionButton',
 					props: {
@@ -821,7 +827,9 @@ export const PublicationConfig = {
 						action: WorkflowActions.WORKFLOW_UNSCHEDULE_PUBLICATION,
 					},
 				});
-			} else if (selectedPublication.status === pkp.const.STATUS_PUBLISHED) {
+			} else if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
+			) {
 				items.push({
 					component: 'WorkflowActionButton',
 					props: {
diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOMP.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOMP.js
@@ -479,7 +479,7 @@ export const PublicationConfig = {
 			if (!permissions.canPublish) {
 				return [];
 			}
-			if (selectedPublication.status === pkp.const.STATUS_QUEUED) {
+			if (selectedPublication.status === pkp.const.PUBLICATION_STATUS_QUEUED) {
 				if (
 					hasSubmissionPassedStage(
 						submission,
@@ -506,7 +506,9 @@ export const PublicationConfig = {
 						action: WorkflowActions.WORKFLOW_SCHEDULE_FOR_PUBLICATION,
 					},
 				});
-			} else if (selectedPublication.status === pkp.const.STATUS_SCHEDULED) {
+			} else if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_SCHEDULED
+			) {
 				items.push({
 					component: 'WorkflowActionButton',
 					props: {
@@ -524,7 +526,9 @@ export const PublicationConfig = {
 						action: WorkflowActions.WORKFLOW_UNSCHEDULE_PUBLICATION,
 					},
 				});
-			} else if (selectedPublication.status === pkp.const.STATUS_PUBLISHED) {
+			} else if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
+			) {
 				items.push({
 					component: 'WorkflowActionButton',
 					props: {
diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOPS.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOPS.js
@@ -220,7 +220,7 @@ export const PublicationConfig = {
 			if (!permissions.canPublish) {
 				return [];
 			}
-			if (selectedPublication.status === pkp.const.STATUS_QUEUED) {
+			if (selectedPublication.status === pkp.const.PUBLICATION_STATUS_QUEUED) {
 				if (
 					hasSubmissionPassedStage(
 						submission,
@@ -247,7 +247,9 @@ export const PublicationConfig = {
 						action: WorkflowActions.WORKFLOW_SCHEDULE_FOR_PUBLICATION,
 					},
 				});
-			} else if (selectedPublication.status === pkp.const.STATUS_SCHEDULED) {
+			} else if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_SCHEDULED
+			) {
 				items.push({
 					component: 'WorkflowActionButton',
 					props: {
@@ -265,7 +267,9 @@ export const PublicationConfig = {
 						action: WorkflowActions.WORKFLOW_UNSCHEDULE_PUBLICATION,
 					},
 				});
-			} else if (selectedPublication.status === pkp.const.STATUS_PUBLISHED) {
+			} else if (
+				selectedPublication.status === pkp.const.PUBLICATION_STATUS_PUBLISHED
+			) {
 				items.push({
 					component: 'WorkflowActionButton',
 					props: {
diff --git a/src/pages/workflow/composables/useWorkflowPermissions.js b/src/pages/workflow/composables/useWorkflowPermissions.js
@@ -52,7 +52,8 @@ export function useWorkflowPermissions({submission, selectedPublication}) {
 
 		if (
 			selectedPublication.value &&
-			selectedPublication.value?.status === pkp.const.STATUS_PUBLISHED
+			selectedPublication.value?.status ===
+				pkp.const.PUBLICATION_STATUS_PUBLISHED
 		) {
 			canEditPublication = false;
 		}
diff --git a/src/pages/workflow/composables/useWorkflowVersionForm.js b/src/pages/workflow/composables/useWorkflowVersionForm.js
@@ -111,7 +111,7 @@ export function useWorkflowVersionForm(
 			// we can safely set the issueId to null and status to STATUS_READY_TO_PUBLISH
 			if (issueCount === 0) {
 				requestBody.issueId = null;
-				requestBody.status = pkp.const.STATUS_READY_TO_PUBLISH;
+				requestBody.status = pkp.const.PUBLICATION_STATUS_READY_TO_PUBLISH;
 			}
 			// Add issue assignment data if in publish mode and issue assignment is provided
 			else {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ export function useWorkflowPermissions({submission, selectedPublication}) {`
`52`	`52`
`53`	`53`	`if (`
`54`	`54`	`selectedPublication.value &&`
`55`		`- selectedPublication.value?.status === pkp.const.STATUS_PUBLISHED`
	`55`	`+ selectedPublication.value?.status ===`
	`56`	`+ pkp.const.PUBLICATION_STATUS_PUBLISHED`
`56`	`57`	`) {`
`57`	`58`	`canEditPublication = false;`
`58`	`59`	`}`