Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model > Secondary Parameters sometimes crashes the React app #590

Open
eatyourgreens opened this issue Nov 26, 2024 · 1 comment
Open

Model > Secondary Parameters sometimes crashes the React app #590

eatyourgreens opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Collaborator

This is tricky to reproduce reliably, but the new Secondary Parameters form can crash the whole React app. It seems to happen when adding/removing variables under the Model > Map Variables view. Checking and unchecking the Secondary Parameters can trigger a crash that renders the whole page as an empty white screen.

  • we should probably have error boundaries so that errors at least show an error message of some sort.
  • the crash itself seems to be this line attempting to map an undefined value.
    return timeIntervals.map((interval) => {
@eatyourgreens eatyourgreens added the bug Something isn't working label Nov 26, 2024
@eatyourgreens eatyourgreens self-assigned this Nov 26, 2024
@eatyourgreens
Copy link
Collaborator Author

No data is lost, so refreshing the page will work as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant