fix case where the storage provider did not encapsulate access to storage. (#16)

Co-authored-by: Carl Alexander Adams <[email protected]>

Author: carl-adams-planet

src/planet_auth/storage_utils.py

@@ -63,6 +63,13 @@ def obj_exists(self, key: ObjectStorageProvider_KeyType) -> bool:
         Check whether a given object exists in storage.
         """
 
+    @abstractmethod
+    def mtime(self, key: ObjectStorageProvider_KeyType) -> float:
+        """
+        Return the last modified time in seconds since the epoc for the object.
+        If the object does not exist, an exception should be raised.
+        """
+
     @abstractmethod
     def obj_rename(self, src: ObjectStorageProvider_KeyType, dst: ObjectStorageProvider_KeyType) -> None:
         """
@@ -181,6 +188,10 @@ def obj_exists(self, key: ObjectStorageProvider_KeyType) -> bool:
         obj_filepath = self._obj_filepath(key)
         return obj_filepath.exists()
 
+    def mtime(self, key: ObjectStorageProvider_KeyType) -> float:
+        obj_filepath = self._obj_filepath(key)
+        return obj_filepath.stat().st_mtime
+
     def obj_rename(self, src: ObjectStorageProvider_KeyType, dst: ObjectStorageProvider_KeyType) -> None:
         src_filepath = self._obj_filepath(src)
         dst_filepath = self._obj_filepath(dst)
@@ -493,7 +504,7 @@ def lazy_reload(self):
             # Have data. No path. Continue with in memory value.
             return
 
-        if int(self._file_path.stat().st_mtime) > self._load_time:
+        if self._object_storage_provider.mtime(self._file_path) > self._load_time:
             self.load()
 
     def lazy_get(self, field):

tests/test_planet_auth/unit/auth/util.py

@@ -455,6 +455,10 @@ def save_obj(self, key: ObjectStorageProvider_KeyType, data: dict) -> None:
     def obj_exists(self, key: ObjectStorageProvider_KeyType) -> bool:
         return key in self._mock_storage
 
+    def mtime(self, key: ObjectStorageProvider_KeyType) -> float:
+        # Fake storage provider.  We don't know when objects were last modified.
+        return 0.0
+
     def obj_rename(self, src: ObjectStorageProvider_KeyType, dst: ObjectStorageProvider_KeyType) -> None:
         if self._mock_storage[src] is not None:
             self._mock_storage[dst] = self._mock_storage[src]