Migrate remaining underscore flags to dash naming

This commit migrates the remaining underscore flags to standardized dash naming:

vtbench:
- unix_socket → unix-socket

mysqlctl:
- mysqlctl_client_protocol → mysqlctl-client-protocol

vtorc:
- clusters_to_watch → clusters-to-watch
- shutdown_wait_time → shutdown-wait-time

All flags now use the utils.SetFlag* functions for consistent naming
and improved user experience.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>

Author: rohit-nayak-ps

go/cmd/vtbench/cli/vtbench.go

@@ -30,6 +30,7 @@ import (
 	"vitess.io/vitess/go/vt/grpccommon"
 	"vitess.io/vitess/go/vt/logutil"
 	"vitess.io/vitess/go/vt/servenv"
+	"vitess.io/vitess/go/vt/utils"
 	"vitess.io/vitess/go/vtbench"
 
 	// Import and register the gRPC vtgateconn client
@@ -139,7 +140,7 @@ func init() {
 
 	Main.Flags().StringVar(&host, "host", host, "VTGate host(s) in the form 'host1,host2,...'")
 	Main.Flags().IntVar(&port, "port", port, "VTGate port")
-	Main.Flags().StringVar(&unixSocket, "unix_socket", unixSocket, "VTGate unix socket")
+	utils.SetFlagStringVar(Main.Flags(), &unixSocket, "unix-socket", unixSocket, "VTGate unix socket")
 	Main.Flags().StringVar(&protocol, "protocol", protocol, "Client protocol, either mysql (default), grpc-vtgate, or grpc-vttablet")
 	Main.Flags().StringVar(&user, "user", user, "Username to connect using mysql (password comes from the db-credentials-file)")
 	Main.Flags().StringVar(&db, "db", db, "Database name to use when connecting / running the queries (e.g. @replica, keyspace, keyspace/shard etc)")

go/flags/endtoend/flags_analysis.json

@@ -74,94 +74,94 @@
     }
   },
   "unique_underscore_flags": [
-    "statsd_sample_rate",
-    "shutdown_wait_time",
-    "action_timeout",
-    "mysql_ldap_auth_method",
-    "restart_before_backup",
-    "topocustomrule_cell",
-    "external_topo_global_server_address",
-    "mysql_timeout",
-    "binlog_player_grpc_server_name",
+    "discovery_low_replication_lag",
     "max_sequence_id",
-    "external_topo_global_root",
-    "enable_online_ddl",
-    "transaction_mode",
-    "min_retention_time",
+    "mysql_auth_vault_ttl",
+    "gateway_initial_tablet_timeout",
+    "max_table_shard_size",
+    "data_dir",
     "bind_variables",
-    "file_backup_storage_root",
-    "tablet_config",
-    "mysql_auth_vault_addr",
-    "unix_socket",
+    "cells_to_watch",
+    "enable_direct_ddl",
+    "min_retention_time",
+    "mysql_ldap_auth_config_file",
+    "mysql_auth_vault_timeout",
+    "external_topo_global_server_address",
+    "clusters_to_watch",
+    "mysql_timeout",
+    "mysql_auth_vault_role_secretidfile",
+    "legacy_replication_lag_algorithm",
+    "allow_first_backup",
     "use_random_sequence",
     "binlog_player_grpc_crl",
-    "rng_seed",
-    "mysql_auth_vault_role_mountpoint",
-    "cells_to_watch",
-    "mysql_auth_vault_path",
-    "num_shards",
-    "binlog_player_grpc_key",
     "vtgate_protocol",
-    "min_retention_count",
-    "rdonly_count",
+    "mysql_auth_vault_addr",
     "mysql_ldap_auth_config_string",
-    "discovery_high_replication_lag_minimum_serving",
-    "mysql_ldap_auth_config_file",
-    "extra_my_cnf",
-    "vschema_ddl_authorized_users",
-    "mysql_auth_vault_role_secretidfile",
-    "min_number_serving_vttablets",
-    "enable_buffer",
-    "mysql_auth_server_static_file",
-    "mysql_auth_vault_tls_ca",
-    "filecustomrules_watch",
-    "external_topo_implementation",
-    "binlog_player_grpc_ca",
+    "mysql_ldap_auth_method",
     "mysql_clientcert_auth_method",
-    "mysql_bind_host",
-    "data_dir",
-    "null_probability",
-    "gateway_initial_tablet_timeout",
-    "enable_direct_ddl",
-    "min_sequence_id",
-    "max_table_shard_size",
-    "replica_count",
-    "mysqlctl_client_protocol",
+    "log_dir",
     "log_link",
-    "log_queries",
-    "log_backtrace_at",
     "enable_system_settings",
-    "mysql_auth_server_static_string",
-    "default_schema_dir",
-    "initial_backup",
-    "persistent_mode",
-    "binlog_player_grpc_cert",
-    "mysql_auth_vault_timeout",
-    "discovery_low_replication_lag",
+    "log_queries",
+    "min_sequence_id",
+    "rng_seed",
     "min_table_shard_size",
-    "mysql_auth_vault_tokenfile",
-    "mysql_auth_static_reload_interval",
+    "replica_count",
+    "statsd_sample_rate",
+    "enable_buffer",
     "min_backup_interval",
-    "default_tablet_type",
+    "mysql_auth_server_static_string",
     "topocustomrule_path",
-    "legacy_replication_lag_algorithm",
+    "binlog_player_grpc_cert",
+    "extra_my_cnf",
+    "vschema_ddl_authorized_users",
+    "null_probability",
+    "mysql_auth_vault_tls_ca",
+    "statsd_address",
+    "persistent_mode",
+    "initial_backup",
+    "action_timeout",
+    "mysql_auth_vault_path",
     "mysql_auth_vault_roleid",
-    "log_dir",
-    "allow_first_backup",
-    "mysql_auth_vault_ttl",
-    "mysql_only",
-    "incremental_from_pos",
-    "clusters_to_watch",
+    "shutdown_wait_time",
+    "external_topo_implementation",
     "snapshot_file",
-    "statsd_address"
+    "mysql_auth_server_static_file",
+    "filecustomrules_watch",
+    "mysql_auth_vault_tokenfile",
+    "incremental_from_pos",
+    "default_tablet_type",
+    "min_retention_count",
+    "mysql_auth_static_reload_interval",
+    "log_backtrace_at",
+    "file_backup_storage_root",
+    "restart_before_backup",
+    "mysql_bind_host",
+    "rdonly_count",
+    "external_topo_global_root",
+    "discovery_high_replication_lag_minimum_serving",
+    "enable_online_ddl",
+    "num_shards",
+    "default_schema_dir",
+    "transaction_mode",
+    "unix_socket",
+    "mysql_only",
+    "binlog_player_grpc_server_name",
+    "mysql_auth_vault_role_mountpoint",
+    "binlog_player_grpc_ca",
+    "min_number_serving_vttablets",
+    "mysqlctl_client_protocol",
+    "topocustomrule_cell",
+    "tablet_config",
+    "binlog_player_grpc_key"
   ],
   "flag_to_binaries": {
     "allow_first_backup": [
       "vtbackup"
     ],
     "file_backup_storage_root": [
-      "vttablet",
       "vtctld",
+      "vttablet",
       "vtbackup"
     ],
     "incremental_from_pos": [
@@ -171,32 +171,32 @@
       "vtbackup"
     ],
     "log_backtrace_at": [
-      "vtcombo",
       "vtorc",
-      "vtbench",
       "vtclient",
       "vttablet",
-      "mysqlctl",
+      "mysqlctld",
+      "vtbackup",
       "vttestserver",
-      "vtgate",
       "vtctld",
-      "mysqlctld",
+      "vtcombo",
       "vtctldclient",
-      "vtbackup"
+      "vtgate",
+      "vtbench",
+      "mysqlctl"
     ],
     "log_dir": [
-      "vtcombo",
       "vtorc",
-      "vtbench",
       "vtclient",
       "vttablet",
-      "mysqlctl",
+      "mysqlctld",
+      "vtbackup",
       "vttestserver",
-      "vtgate",
       "vtctld",
-      "mysqlctld",
+      "vtcombo",
       "vtctldclient",
-      "vtbackup"
+      "vtgate",
+      "vtbench",
+      "mysqlctl"
     ],
     "min_backup_interval": [
       "vtbackup"
@@ -214,9 +214,9 @@
       "vtbackup"
     ],
     "action_timeout": [
-      "vtctldclient",
       "vtctld",
-      "vtcombo"
+      "vtcombo",
+      "vtctldclient"
     ],
     "log_link": [
       "vtctldclient"
@@ -242,18 +242,18 @@
       "vtgate"
     ],
     "enable_direct_ddl": [
-      "vttestserver",
       "vtcombo",
+      "vttestserver",
       "vtgate"
     ],
     "enable_online_ddl": [
-      "vttestserver",
       "vtcombo",
+      "vttestserver",
       "vtgate"
     ],
     "enable_system_settings": [
-      "vttestserver",
       "vtcombo",
+      "vttestserver",
       "vtgate"
     ],
     "gateway_initial_tablet_timeout": [
@@ -314,21 +314,21 @@
       "vtgate"
     ],
     "statsd_address": [
-      "vtgate",
-      "vttablet"
+      "vttablet",
+      "vtgate"
     ],
     "statsd_sample_rate": [
-      "vtgate",
-      "vttablet"
+      "vttablet",
+      "vtgate"
     ],
     "transaction_mode": [
-      "vttestserver",
       "vtcombo",
+      "vttestserver",
       "vtgate"
     ],
     "vschema_ddl_authorized_users": [
-      "vttestserver",
       "vtcombo",
+      "vttestserver",
       "vtgate"
     ],
     "clusters_to_watch": [

go/vt/mysqlctl/mysqlctlclient/interface.go

@@ -27,6 +27,7 @@ import (
 	"vitess.io/vitess/go/vt/log"
 	mysqlctlpb "vitess.io/vitess/go/vt/proto/mysqlctl"
 	"vitess.io/vitess/go/vt/servenv"
+	"vitess.io/vitess/go/vt/utils"
 )
 
 var protocol = "grpc"
@@ -36,7 +37,7 @@ func init() {
 }
 
 func registerFlags(fs *pflag.FlagSet) {
-	fs.StringVar(&protocol, "mysqlctl_client_protocol", protocol, "the protocol to use to talk to the mysqlctl server")
+	utils.SetFlagStringVar(fs, &protocol, "mysqlctl-client-protocol", protocol, "the protocol to use to talk to the mysqlctl server")
 }
 
 // MysqlctlClient defines the interface used to send remote mysqlctl commands

go/vt/vtorc/logic/tablet_discovery.go

@@ -37,6 +37,7 @@ import (
 	topodatapb "vitess.io/vitess/go/vt/proto/topodata"
 	"vitess.io/vitess/go/vt/topo"
 	"vitess.io/vitess/go/vt/topo/topoproto"
+	"vitess.io/vitess/go/vt/utils"
 	"vitess.io/vitess/go/vt/vtorc/config"
 	"vitess.io/vitess/go/vt/vtorc/db"
 	"vitess.io/vitess/go/vt/vtorc/inst"
@@ -117,8 +118,8 @@ func getEmergencyReparentShardDisabledStats() map[string]int64 {
 
 // RegisterFlags registers the flags required by VTOrc
 func RegisterFlags(fs *pflag.FlagSet) {
-	fs.StringSliceVar(&clustersToWatch, "clusters_to_watch", clustersToWatch, "Comma-separated list of keyspaces or keyspace/keyranges that this instance will monitor and repair. Defaults to all clusters in the topology. Example: \"ks1,ks2/-80\"")
-	fs.DurationVar(&shutdownWaitTime, "shutdown_wait_time", shutdownWaitTime, "Maximum time to wait for VTOrc to release all the locks that it is holding before shutting down on SIGTERM")
+	utils.SetFlagStringSliceVar(fs, &clustersToWatch, "clusters-to-watch", clustersToWatch, "Comma-separated list of keyspaces or keyspace/keyranges that this instance will monitor and repair. Defaults to all clusters in the topology. Example: \"ks1,ks2/-80\"")
+	utils.SetFlagDurationVar(fs, &shutdownWaitTime, "shutdown-wait-time", shutdownWaitTime, "Maximum time to wait for VTOrc to release all the locks that it is holding before shutting down on SIGTERM")
 }
 
 // initializeShardsToWatch parses the --clusters_to_watch flag-value