Skip to content

Commit 0d7912c

Browse files
authored
Fix: [KRAANG-7741] PlanGrid: when viewing photos from documents and using arrows to go to next photo the image doesn't change (#245)
* remove node-sass, upgrade npm, add sass, update sass-loader config Note that node-sass is deprecated, and the version that was installed does not compile on arm64. Also updated README.md * upgrade react minor version * add image swapping demo * fix PhotoViewerWrapper so it loads a new image if the filePath prop changes and update the demo to show that the image can be swapped * 1.2.4-fix-photo-viewer.0 * 1.2.4-fix-photo-viewer.1 * do not minify, ship source map * 1.2.4-fix-photo-viewer.2
1 parent 6f9348c commit 0d7912c

File tree

7 files changed

+17981
-760
lines changed

7 files changed

+17981
-760
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ purposes. It is by default served via webpack-dev-server.
7272

7373
### To start demo app
7474

75-
`make start` will start the demo app served by webpack-dev-server
75+
`npm run start` will start the demo app served by webpack-dev-server
7676

7777
### Testing
7878

@@ -81,7 +81,7 @@ Tests use Jest and Enzyme.
8181
Run tests with:
8282

8383
```
84-
make test
84+
npm run test
8585
```
8686

8787
This starts Jest in watch mode. To run a particular test file, while in watch mode
@@ -97,7 +97,7 @@ npm run jest --updateSnapshot
9797

9898
### To run the linter
9999

100-
`make lint`
100+
`npm run lint`
101101

102102
### Extending the file viewer
103103

0 commit comments

Comments
 (0)