Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple photos not working #87

Open
rameshbansal opened this issue Jan 8, 2019 · 7 comments · May be fixed by #119
Open

Multiple photos not working #87

rameshbansal opened this issue Jan 8, 2019 · 7 comments · May be fixed by #119

Comments

@rameshbansal
Copy link

rameshbansal commented Jan 8, 2019 •
edited
Loading

All images went into the same container pg-photo-container
@TheThirdDave
Copy link

TheThirdDave commented Jan 16, 2019 •
edited
Loading

I ran into this issue as well and think I may have a fix for it.

Was looking into the code and noticed the driver uses document.getElementById to append the images to a <div> with the id pg-photo-container. I think replacing this and using React.createRef() to append the image to the div could solve the issue. Anyone else have any thoughts?

@basitsattar
Copy link

Any update about this?

@TheThirdDave
Copy link

Yes! Sorry haven't had a chance to get back to this but I did get the fix working for this.

Haven't made a pull request yet for it though. The fix though is replacing uses of document.getElementById with React References instead.

@macrozone
Copy link

macrozone commented Oct 28, 2019 •
edited
Loading

yeah, using ids is a big no-go in javascript and in particular in react. Has anyone forked and fixed that? should be really easy though. Will provide a PR soon if the contributors will merge

@macrozone macrozone linked a pull request Nov 7, 2019 that will close this issue
Open
@thefedoration
Copy link

This PR addresses this issue: #119
Can we review it please?

@macrozone
Copy link

@thefedoration unfortunalty plangrid abondoned this package

@kgdiem
Copy link

kgdiem commented Apr 23, 2021

@michaelwolo Are you open to new maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: multiple viewers fill in the same container panter/react-file-viewer
6 participants
@macrozone @TheThirdDave @thefedoration @basitsattar @rameshbansal @kgdiem