New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIP and RouterID should have no default value #46

Open

dlipovetsky opened this issue Jul 31, 2018 · 2 comments

Labels

bug

Contributor

dlipovetsky commented Jul 31, 2018

These are optional, and default values would only work by the oddest of coincidences. Also see platform9/cctl#38.

dlipovetsky added the bug label

Contributor

puneetguptanitj commented Oct 12, 2018

fixed as part of platform9/cctl@d903397#diff-e03d5f99bf4d1df790bad760763561fb

puneetguptanitj closed this as completed

Contributor Author

dlipovetsky commented Jan 5, 2019

The defaults are still present, and applied here: https://github.com/platform9/nodeadm/blob/master/utils/install.go#L212

dlipovetsky reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment