From 2638495cd95732508d7ebf39a773acddf6403498 Mon Sep 17 00:00:00 2001 From: Karl-Aksel Puulmann Date: Thu, 27 Jun 2024 10:06:48 +0300 Subject: [PATCH] Re-simplify get_revenue_tracking_currency --- extra/lib/plausible/stats/goal/revenue.ex | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/extra/lib/plausible/stats/goal/revenue.ex b/extra/lib/plausible/stats/goal/revenue.ex index 55bf70d4760a..67730058f387 100644 --- a/extra/lib/plausible/stats/goal/revenue.ex +++ b/extra/lib/plausible/stats/goal/revenue.ex @@ -32,9 +32,7 @@ defmodule Plausible.Stats.Goal.Revenue do ) end - @spec get_revenue_tracking_currency(Plausible.Site.t() | nil, Plausible.Stats.Query.t(), [ - atom() - ]) :: + @spec get_revenue_tracking_currency(Plausible.Site.t(), Plausible.Stats.Query.t(), [atom()]) :: {atom() | nil, [atom()]} @doc """ Returns the common currency for the goal filters in a query. If there are no @@ -60,7 +58,7 @@ defmodule Plausible.Stats.Goal.Revenue do Plausible.Billing.Feature.RevenueGoals.check_availability(site.owner) == :ok end - if site && requested_revenue_metrics? && filtering_by_goal? && revenue_goals_available?.() do + if requested_revenue_metrics? && filtering_by_goal? && revenue_goals_available?.() do revenue_goals_currencies = Plausible.Repo.all( from rg in Ecto.assoc(site, :revenue_goals),