Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common asset management system interface #1224

Open
kpal81xd opened this issue Nov 13, 2024 · 2 comments
Open

Common asset management system interface #1224

kpal81xd opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@kpal81xd
Copy link

kpal81xd commented Nov 13, 2024

The editor manages assets through the editor-api however both the code editor and launcher manage them individually using their own ObserverLists. This needs to be have a common interface to apply for all pages

@kpal81xd kpal81xd self-assigned this Nov 13, 2024
@Maksims
Copy link
Collaborator

Maksims commented Nov 13, 2024

Why do they need to be changed and use the same management system?
Does it bring new features?
Is there a problem that needs to be fixed and it is the only way?

Launcher - only need to know about some assets (not every), and only have to react to its changes.
Code Editor only need to know about Script, Text, JSON, etc. types of assets, and have very limited level of control over them.
Editor - have full access to all assets, and can change anything about them.

So they are different contexts, and have different level of access also. I would not want Launcher to be able to have access to change assets, as it is a security concern. It should be running on read-only mode with limited access to assets. And have a separate token to ensure XSS would not be a risk.

@kpal81xd
Copy link
Author

Security concern wise I agree you want the scope to be limited. Ive updated the description to make it clear its for a common interface amongst all pages to replicate behavior across multiple pages - such as in the example of parsing the scripts. Managing separate code for how the editor and code-editor makes it difficult to track and fix issues such as this.

@kpal81xd kpal81xd changed the title Asset managment system Common asset management system interface Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants