Skip to content

make install fails on the addon template when jq is not installed #382

Description

@kittauri

Describe the bug

When running make install in a scaffolded addon project by uvx cookieplone the installation fails when jq is not installed. The tool jq is not listed as a requirement for cookieplone.

This leads to an empty version string:

Makefile (addon)

export PLONE_VERSION := $(shell echo '$(REPOSITORY_SETTINGS)' | jq -r '.backend.base_package_version')

Makefile (backend):
@echo '-c https://dist.plone.org/release/$(PLONE_VERSION)/constraints.txt' > requirements.txt

The variable $(PLONE_VERSION) is empty resulting in Exception: Failed to fetch 'https://dist.plone.org/release//constraints.txt': HTTP Error 404: Not Found

instead of https://dist.plone.org/release/6.1.4/constraints.txt

To Reproduce

Steps to reproduce the behavior:

  1. Check that jq is not installed
  2. Create a addon project scaffold with uvx cookieplone
  3. Run make install
  4. See error

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions