Skip to content

make clean wipes project folder and potentially other folders if path contains spaces #401

Description

@ninamuecke

Describe the bug

The make file doesn't handle paths with spaces correctly. make clean wiped whole folders and I didn't know why, until I printed out the BACKEND_FOLDER.

My actual path is:
/Users/name/Repositories/Plone/Upgrade Plone Packages/new-packages/my.project
but the BACKEND_FOLDER in the makefile is for some reason resolved to:
/Users/name/Repositories/Plone . Packages/new-packages/my.project

and so make clean executes (@rm -rf $(VENV_FOLDER) pyvenv.cfg ...):
@rm -rf /Users/name/Repositories/Plone . Packages/new-packages/my.project pyvenv.cfg ...
which removes whole folders which were not supposed to be removed.

To Reproduce

Steps to reproduce the behavior:

  1. Create a project/addon inside a folder with spaces in the path
  2. Run any make command, e.g. make install(preferably not make clean unless you want to wipe your folder like I accidentally did :))
  3. See error

Expected behavior

I expected that make clean wouldn't remove folders I still need.

Software:

  • OS: macOS Sonoma 14.4.1
  • Plone Version: 6.2.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions