Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing_content tile for Plone 6.1 without portal_properties #159

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

pbauer
Copy link
Sponsor Member

@pbauer pbauer commented Sep 23, 2024

No description provided.

@petschki
Copy link
Member

petschki commented Sep 23, 2024

I tried to review that but its not possible, because the view_template Choice field is required but the default vocabulary only returns one entry with an empty value: https://github.com/plone/plone.app.standardtiles/blob/main/src/plone/app/standardtiles/existingcontent.py#L272 ... should we change this field to required=False instead? If the field is empty, the factory reads the default layout anyways https://github.com/plone/plone.app.standardtiles/blob/main/src/plone/app/standardtiles/existingcontent.py#L177 ...

@pbauer
Copy link
Sponsor Member Author

pbauer commented Sep 27, 2024

The result would be that the choice-field has "No Value" and "Default view" and both will have the same effect. That might be confusing.
I'd rather use some default-value and handle that in def content_view_name.

@petschki petschki merged commit 0d4aaf8 into main Sep 30, 2024
11 checks passed
@petschki petschki deleted the fix_plone61 branch September 30, 2024 07:36
@petschki
Copy link
Member

Released as 3.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants