Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /voltohandson/footer.html #681

Open
flipmcf opened this issue Nov 1, 2022 · 1 comment
Open

Issue on page /voltohandson/footer.html #681

flipmcf opened this issue Nov 1, 2022 · 1 comment

Comments

@flipmcf
Copy link
Contributor

flipmcf commented Nov 1, 2022

Should we be throwing css into custom.overrides? Would it be better practice to create a .less file inside our Footer directory and import it into footer.jsx

It might lead to bad habits... but maybe there was a good reason to use the overrides.

@tiberiuichim
Copy link
Contributor

I think it's fine to have CSS in custom.overrides. There are a few (minor) differences in how the (generated) CSS loaded from components gets bundled into the CSS bundles, but the main one is that the css from .overrides will be closer to the "original" intended destination, the main CSS theme.

Having said that, I wouldn't worry too much about this issue. Just pick one style and be consistent with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants