Skip to content

Commit e416b40

Browse files
committed
PR suggestions
1 parent 91c5b11 commit e416b40

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

assets/dismiss-review.png

118 KB
Loading

contributing/responding-pr-review.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ all observations but you should respond to all of them with a informative commen
99
the reviewer knows what you did (addressed the changes, have questions about their
1010
observations, etc.)
1111

12+
It's okay and often faster to use Slack to resolve any disagreement, confusion,
13+
or ambiguity and then update the thread once consensus is reached.
14+
1215
If a code change has been made, include a link to the changes so the reviewer
1316
can find them quickly. First, click on `Files changed` in your PR:
1417

@@ -30,9 +33,9 @@ Then, your response can be:
3033
[fixed](https://github.com/ploomber/jupysql/pull/787/files#diff-15ef0e119ce73b542976f499fcc3cbb967d30af8199e058aec2bc77c30973061R105-R114)
3134
```
3235

33-
## **Do not** mark the conversations as resolved
36+
## **Do not** mark the conversations as resolved or dismiss reviews
3437

3538
The reviewer is responsible for making conversations as resolved.
3639

3740
![](../assets/resolve-conversation.png)
38-
41+
![](../assets/dismiss-review.png)

0 commit comments

Comments
 (0)