diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ed4ce27..6209e71 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,6 +35,7 @@ jobs: run: | python -m pip install --upgrade pip pip install . + pip install "matplotlib<3.7" "numpy<1.24.2" # check package is importable python -c "import ploomber_engine" diff --git a/tests/test_execute.py b/tests/test_execute.py index df170cc..0954062 100644 --- a/tests/test_execute.py +++ b/tests/test_execute.py @@ -369,10 +369,7 @@ def test_execute_notebook_invalid_save_profiling_data( # seems like we have some shared state, we're getting a plot even though the # code is only printing the current working directory, the problem is in the line: # self._shell._get_output() -# this started happening after removing the matplotlib<3.7 pin -@pytest.mark.skip( - reason="skip. this started failing after we removed the matplotlib<3.7 pin" -) +# this happens if we remove the pip install "matplotlib<3.7" "numpy<1.24.2" from ci.yml def test_execute_notebook_different_cwd(tmp_empty): # setup run_dir = Path("run_dir") diff --git a/tests/test_memory_release_nb.py b/tests/test_memory_release_nb.py index b783ae0..a1ff969 100644 --- a/tests/test_memory_release_nb.py +++ b/tests/test_memory_release_nb.py @@ -42,9 +42,6 @@ def new_exit(self, exc_type, exc_value, traceback): return new_exit -@pytest.mark.skip( - reason="skip. this started failing after we removed the matplotlib<3.7 pin" -) def test_if_memory_leak_within_notebook(path_notebook): """ epsilon is an amount of memory that is negligeable with respect diff --git a/tests/test_testing.py b/tests/test_testing.py index 52ffd8e..eb65f0f 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -31,9 +31,6 @@ def edit_nb(cells): nbformat.write(nb, "nb.ipynb") -@pytest.mark.skip( - reason="skip. this started failing after we removed the matplotlib<3.7 pin" -) def test_no_outputs(tmp_empty): make_and_execute_nb(["x = 1", "y = 2"])