Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client #2

Open
edublancas opened this issue Jul 20, 2022 · 0 comments
Open

fix client #2

edublancas opened this issue Jul 20, 2022 · 0 comments

Comments

@edublancas
Copy link
Contributor

edublancas commented Jul 20, 2022

to enable stdin, we had to modify nbclient; however, since nbclient does not have to support the stdin channel, the code doesn't set a timeout for the channels, since it assumes all messages will return a response via the shell and io_pub; this causes out modification to hang up. The quick fix is to add a little time.sleep call to ensure that cells asking for input are correctly handled; but we should fix this

we can use this as inspiration: https://github.com/jupyter/jupyter_console/blob/main/jupyter_console/ptshell.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant