Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"I should go vegan" has returned a few false positives #12

Open
plorry opened this issue Nov 3, 2015 · 2 comments · Fixed by #13
Open

"I should go vegan" has returned a few false positives #12

plorry opened this issue Nov 3, 2015 · 2 comments · Fixed by #13

Comments

@plorry
Copy link
Owner

plorry commented Nov 3, 2015

It's a useful phrase to have in there, but so far it's matched probably around three or four tweets where the person's sentiment was along the lines of "don't tell me I should go vegan" or "my cousin told me if I'm feminist I should go vegan and I got so pissed" (paraphrased examples).
We generally only wanna retweet people who would like to be contacted by friendly vegans, so these are clear misses.
(I've so far manually unretweeted these instances as they come up.)
I don't know exactly how to catch these, but maybe I could log the next few and see if they follow a pattern that could at least catch most cases.

@squeek502
Copy link
Collaborator

A simple alteration that might do pretty well is to require the phrase to be at the start of the tweet, so that I should go vegan matches but Don't tell me I should go vegan doesn't.

Not sure if that'd exclude too much.

squeek502 added a commit to squeek502/VegAssist that referenced this issue Nov 3, 2015
 * A simple hack for excluding things like "don't tell me I should go vegan"
 * Fixes plorry#12
@plorry plorry closed this as completed in #13 Nov 3, 2015
@squeek502
Copy link
Collaborator

Re-opening so that we don't forget that the current fix could/should be improved.

@squeek502 squeek502 reopened this Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants