From c434f9ed0519c1b37c10d6e1935afed525f6aa09 Mon Sep 17 00:00:00 2001 From: squeek Date: Mon, 2 Nov 2015 20:01:10 -0800 Subject: [PATCH] Force "I should go/be vegan" phrase to be at the start of a tweet * A simple hack for excluding things like "don't tell me I should go vegan" * Fixes #12 --- filters/english.js | 3 ++- test/test-filter.js | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/filters/english.js b/filters/english.js index 489085d..a6ff287 100644 --- a/filters/english.js +++ b/filters/english.js @@ -17,7 +17,8 @@ var robustRegex = function(regexStr, flags) { module.exports = [ robustRegex( "help me (be( a)?|become( a)?|go) #?vegan" ), robustRegex( "i (" + adverbsRegexSet + ")? ?(want to|wanna|would like to) (be( a)?|become( a)?|go) #?vegan" ), - robustRegex( "i (" + adverbsRegexSet + ")? ?(should) (go|be) #?vegan" ), + // forcing this to be at the start of the tweet is a simple hack for excluding things like "don't tell me I should go vegan" + robustRegex( "^(i think)? ?i (" + adverbsRegexSet + ")? ?(should) (go|be) #?vegan" ), robustRegex( "i (" + adverbsRegexSet + ")? ?(will|do)? ?(need|want) help (going|becoming( a)?|being( a)?|staying( a)?) #?vegan" ), robustRegex( "i (" + adverbsRegexSet + ")? ?(want to|wanna|would like to|should) (try) (going|becoming( a)?|being( a)?) #?vegan" ), robustRegex( "i('| a)?m (considering|thinking (about|of)|mulling over) (going|becoming( a)?|being( a)?) #?vegan" ), diff --git a/test/test-filter.js b/test/test-filter.js index d1a5a0e..065209d 100644 --- a/test/test-filter.js +++ b/test/test-filter.js @@ -46,6 +46,7 @@ var matches = [ var falsePositives = [ "I do not want to go vegan", "I should be a vegan", // this phrasing more than likely isn't about going vegan long-term (e.g. I should be a vegan for Halloween) + "Don't tell me I should go vegan", ]; exports.matches = function(test) {