Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound on werkzeug [dependency] #3096

Open
marcstern14 opened this issue Nov 27, 2024 · 5 comments
Open

Remove upper bound on werkzeug [dependency] #3096

marcstern14 opened this issue Nov 27, 2024 · 5 comments
Labels
dependencies Pull requests that update a dependency file P2 considered for next cycle

Comments

@marcstern14
Copy link

werkzeug currently has an upper bound <3.1. There are more updated versions, which are compatible within the current Flask boundaries. Bumping the allowed versions of werkzeug would help for more flexible dependency installs for apps, and setting werkzeug>=3.0.6 would prevent triggering snyk vulnerabilities: https://security.snyk.io/vuln/SNYK-PYTHON-WERKZEUG-8309092

I've provided a PR here: #3095

@marcstern14 marcstern14 changed the title Remove upper bound on werkzeug Remove upper bound on werkzeug [dependency] Nov 27, 2024
@alexcjohnson
Copy link
Collaborator

See #2538 and the community forum discussion mentioned there for context around our decision to restrict Flask and Werkzeug versions. I'm still strongly in favor of continuing the current approach of bumping these upper bounds only after we've tested them throughout the Dash ecosystem.

@marcstern14
Copy link
Author

Hmm ok, I see that this issue has been discussed at length in the past. Considering the last bump of werkzeug was over a year ago, could there be plans to test bumping it again?

@alexcjohnson
Copy link
Collaborator

Absolutely - part of deciding to restrict it was that then it’s incumbent on us as maintainers to keep up with new versions and this one has been waiting too long. I’ll have to defer to @T4rk1n and @gvwilson, who are focused on getting v3 released shortly, but I would imagine this can be prioritized soon after that.

@marcstern14
Copy link
Author

Sounds great! All your work is much appreciated – looking forward to tracking the progress.

@gvwilson gvwilson added P2 considered for next cycle dependencies Pull requests that update a dependency file labels Dec 3, 2024
@yuvashrikarunakaran
Copy link
Contributor

Issue Description
Current Constraint: The werkzeug dependency has an upper bound set to <3.1.
Problem: This constraint:
Blocks the use of more recent, compatible versions of werkzeug.
Causes challenges in dependency management for applications that integrate with this project.
Triggers vulnerabilities in older versions of werkzeug, such as those reported by Snyk (e.g., SNYK-PYTHON-WERKZEUG-8309092).
Proposed Solution
Remove Upper Bound: Update the dependency requirements to werkzeug>=3.0.6, allowing for greater flexibility while addressing security vulnerabilities.
Pull Request: A PR (#3095) has been submitted to implement this change.
Advantages of This Change
Enhanced Security: Ensures users can adopt patched and secure versions of werkzeug.
Improved Compatibility: Allows the project to integrate with a wider range of dependencies, avoiding conflicts in modern Flask applications.
Future-Proofing: Reduces the risk of frequent updates being needed for dependency constraints.
Action Items
Review PR #3095: Verify the compatibility of newer werkzeug versions with the project.
Run Tests: Confirm that the change does not introduce regressions or unexpected behavior.
Merge & Release: If tests pass, approve and merge the PR, and release a new version of the project with the updated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file P2 considered for next cycle
Projects
None yet
Development

No branches or pull requests

4 participants