Skip to content

Commit 8961487

Browse files
committed
Update/remove CCI references
1 parent 7563354 commit 8961487

4 files changed

Lines changed: 20 additions & 23 deletions

File tree

.github/scripts/test.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
#!/bin/bash
22

3-
# GitHub Actions version of .circleci/test.sh
4-
# Replaces `circleci tests split` with split_files.mjs
5-
63
set +e
74
set +o pipefail
85

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ npm-debug.log*
1313
tags
1414

1515
.*
16-
!.circleci
1716
!.github/
1817
!.gitignore
1918
!.npmignore

CONTRIBUTING.md

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,8 @@ compliance, and so for strict builds we pre-generate regl shader code here.
186186

187187
## Testing
188188

189-
Both jasmine and image tests are run on
190-
[CircleCI](https://circleci.com/gh/plotly/plotly.js) on every push to this
189+
Both Jasmine and image tests are run on
190+
[GitHub Actions](https://github.com/plotly/plotly.js/actions/workflows/ci.yml) on every push to this
191191
repo.
192192

193193
### Jasmine tests
@@ -240,30 +240,31 @@ npm run test-jasmine -- --info
240240
```
241241

242242
### Draft new baselines
243-
#### With docker:
244-
> If you prefer using docker each time you need to
243+
244+
#### With Docker:
245245
```sh
246-
docker run -it -v "$(pwd)":/plotly.js circleci/python:3.8.9 bash
247-
# then inside the docker
248-
cd plotly.js
249-
sudo bash .circleci/env_image.sh
246+
docker run -it -v "$(pwd)":/plotly.js python:3.12 bash
247+
# Then inside the container
248+
cd /plotly.js
249+
pip install uv
250+
bash .github/scripts/env_image.sh
250251
```
251252

252-
#### Without docker:
253-
> Otherwise you may need to install `python 3.8`
254-
Then upgrade `pip` if needed
253+
#### Without Docker:
254+
Ensure you have Python 3.12+ and [`uv`](https://docs.astral.sh/uv/) installed.
255+
256+
To install required fonts and tools, run the [setup script](https://github.com/plotly/plotly.js/blob/master/.github/scripts/env_image.sh):
255257
```sh
256-
python3 -m pip install --upgrade pip
258+
bash .github/scripts/env_image.sh
257259
```
258260

259-
To install required fonts and tools see this [shell script](https://github.com/plotly/plotly.js/blob/master/.circleci/env_image.sh).
261+
#### Scripts to generate/update new baselines with/without Docker:
260262

261-
#### Scripts to generate/update new baselines with/without docker:
262263
```sh
263264
python3 test/image/make_baseline.py = mock_1 mock_2
264265
```
265266

266-
> Alternatively using npm & node.js (which are not available in the python docker by default)
267+
Alternatively, you can use Node:
267268

268269
```sh
269270
npm run baseline mock_1 mock_2
@@ -287,10 +288,11 @@ If you added new mocks to test/image/mocks folder, to generate draft baselines r
287288
```sh
288289
python3 test/image/make_baseline.py = mockFilename1 mockFilename2
289290
```
291+
290292
Then commit the new baselines and push.
291-
Please note that image pixel comparison tests run using circleci/python:3.8.9 docker container.
293+
Please note that image pixel comparison tests run on `ubuntu-latest` in GitHub Actions.
292294
Therefore the final baselines may need updates.
293-
This could simply be done by downloading the `baselines.tar` stored in the `ARTIFACTS` tab of `test-baselines` job (if the test failed).
295+
This could simply be done by downloading the baseline images from the **Artifacts** section of the `test-baselines` job in the failed workflow run.
294296

295297
### Using the developer console in karma to write/debug jasmine tests
296298

@@ -390,4 +392,3 @@ Other methods used by some trace modules:
390392
## Coding style
391393

392394
Check if OK with `npm run lint`
393-

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<a href="https://plotly.com/javascript/"><img src="https://images.plot.ly/logo/plotlyjs-logo@2x.png" height="70"></a>
22

33
[![npm version](https://badge.fury.io/js/plotly.js.svg)](https://badge.fury.io/js/plotly.js)
4-
[![circle ci](https://circleci.com/gh/plotly/plotly.js.svg?style=shield)](https://circleci.com/gh/plotly/plotly.js)
4+
[![CI](https://github.com/plotly/plotly.js/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/plotly/plotly.js/actions/workflows/ci.yml)
55
[![MIT License](https://img.shields.io/badge/License-MIT-brightgreen.svg)](https://github.com/plotly/plotly.js/blob/master/LICENSE)
66

77
[Plotly.js](https://plotly.com/javascript) is a standalone JavaScript data visualization library, and it also powers the Python and R modules named `plotly` in those respective ecosystems (referred to as [Plotly.py](https://plotly.com/python) and [Plotly.R](http://plotly.com/r)).

0 commit comments

Comments
 (0)