update commands.py and CONTRIBUTING.md to reflect the fact that JS build artifacts must be updated when updating plotly.js version

Author: emilykl

CONTRIBUTING.md

@@ -273,22 +273,24 @@ python commands.py updateplotlyjs
 ```
 
 This downloads new versions of `plot-schema.json` and `plotly.min.js` from the `plotly/plotly.js` GitHub repository
-and places them in `plotly/package_data`.
-It then regenerates all of the `graph_objs` classes based on the new schema,
-and finally runs `npm install` in `js/` to refresh `js/package-lock.json` against the new `plotly.js`.
-Commit the updated `js/package-lock.json` along with the regenerated files.
+and places them in `codegen/resources/` and `plotly/package_data/`, respectively.
 
-The JupyterLab extension and FigureWidget bundles in `plotly/labextension` and `plotly/package_data/widgetbundle.js`
-are rebuilt as part of the release flow (see [RELEASE.md](RELEASE.md)) rather than on every plotly.js bump.
+It then does the following:
+ - Regenerates all of the `graph_objs` classes based on the new schema
+ - Runs `npm install` in `js/`to refresh `js/package-lock.json` against the new `plotly.js`
+ - Runs `npm run build` to rebuild the JupyterLab extension and FigureWidget bundles in `plotly/labextension` and `plotly/package_data/widgetbundle.js`.
 
-If you need to skip the `npm install` step entirely (e.g. `npm` isn't available),
+Commit the updated files under `js/`, `plotly/graph_objs/`, `plotly/offline/` `codegen/resources/`, and `plotly/package_data/`.
+
+If you need to skip the `npm` steps entirely (e.g. `npm` isn't available),
 set the `SKIP_NPM=1` environment variable:
 
 ```bash
 SKIP_NPM=1 python commands.py updateplotlyjs
 ```
 
-If you do skip it, you'll need to run `npm install` in `js/` yourself before committing so the lockfile stays in sync.
+If you do skip it, you'll need to find a way to manually run `npm install && npm run build` in `js/` before committing,
+so that the lockfile and build artifacts stay in sync with `js/package.json`.
 
 ### Using a Development Branch of Plotly.js
 

commands.py

@@ -50,8 +50,8 @@ def install_js_deps(local, build=True):
     When ``build`` is True (the default), also runs ``npm run build`` to
     rebuild the JupyterLab extension and FigureWidget bundles and verifies
     that the widget bundle exists. Pass ``build=False`` when you only need
-    to refresh ``node_modules`` / ``package-lock.json`` (e.g. after a
-    plotly.js version bump) and don't need the bundles rebuilt.
+    to refresh ``node_modules`` / ``package-lock.json`` but don't
+    need the bundles rebuilt.
     """
 
     npmName = "npm"
@@ -224,7 +224,7 @@ def update_plotlyjs(plotly_js_version, outdir):
     update_bundle(plotly_js_version)
     update_schema(plotly_js_version)
     perform_codegen(outdir)
-    install_js_deps(local=None, build=False)
+    install_js_deps(local=None, build=True)
 
 
 # FIXME: switch to argparse