Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaleido doesn't generate the image output on MacOS #241

Open
alceal opened this issue Nov 2, 2024 · 9 comments
Open

Kaleido doesn't generate the image output on MacOS #241

alceal opened this issue Nov 2, 2024 · 9 comments
Labels
kaleido Issue related to Kaleido dependency

Comments

@alceal
Copy link

alceal commented Nov 2, 2024

I'm using the example from the README.md to test the write_image function, but it neither generates nor panics. I'm on MacOS 15.0.1 (Sequoia).

plotly = { version = "0.10.0", features = ["kaleido"]}
use plotly::{ImageFormat, Plot, Scatter};

fn main() {
    let mut plot = Plot::new();
    let trace = Scatter::new(vec![0, 1, 2], vec![2, 1, 0]);
    plot.add_trace(trace);

    plot.write_image("out.png", ImageFormat::PNG, 800, 600, 1.0);
}
@andrei-ng
Copy link
Collaborator

andrei-ng commented Nov 4, 2024

@alceal thanks for reporting the issue. I was under the false impression that only the CI had issues. This means that indeed there is something wrong on MacOS. I will try to see if I can get to the bottom of it using the GitHub runners (don't own a Mac) .
It might also be a Kaleido issue in itself, not a plotly-rs one, but worth looking into.

@ndrezn
Copy link
Member

ndrezn commented Nov 22, 2024

Just a heads up, we're working on a rebuild of Kaleido. The new versions are on PyPi as v1.0.0rc0. See: https://github.com/plotly/kaleido for a bit more. I'm not sure how Kaleido is integrated into plotly.rs but if there is a coupling on the PyPi project this may have broken it.

We released a few minors (v0.4.0-v0.4.2) but we yanked them as we worked out naming scheme: This is a complete rebuild so we might end up publishing it under a new name.

The timing of this ticket is about when we published the new versions, but as they're now yanked I wouldn't expect further issues.

@andrei-ng
Copy link
Collaborator

andrei-ng commented Nov 23, 2024

Hi Nathan, thank you for this info. I noticed that Greg commented on a few tickets on other projects related to Kaleido that a new version is coming out and I am looking forward to that. There is something broken in Kaleido or our integration with which causes this issue on plotly-rs, just didn't have the time to look into it. Will have to take the leap soon.

We are using an older version though. Need to check if the newer release candidate improves things. FYI , in this crate, Kaleido gets downloaded at build time on the users machine and the package version is hardcoded here https://github.com/plotly/plotly.rs/blob/main/plotly_kaleido/build.rs

@andrei-ng
Copy link
Collaborator

Hi @alceal, is the architecture of your Mac by any chance arm?

@emilbratt
Copy link

emilbratt commented Nov 28, 2024

Hi @alceal, is the architecture of your Mac by any chance arm?

@andrei-ng
Not the person you asked, but I wanted to share that I tried this on my Macbook Air to verify.
It does indeed hang (no panic and nothing generated), just as described in this issue.

MacOS Sonoma 14.1.1 (23B81)
Arm CPU (the M1 Apple silicon)

@andrei-ng
Copy link
Collaborator

Hi @alceal, is the architecture of your Mac by any chance arm?

@andrei-ng Not the person you asked, but I wanted to share that I tried this on my Macbook Air to verify. It does indeed hang (no panic and nothing generated), just as described in this issue.

MacOS Sonoma 14.1.1 (23B81) Arm CPU (the M1 Apple silicon)

Thank you @emilbratt!

@andrei-ng
Copy link
Collaborator

Been trying to track down the problem. It seems that is an Apple M1 Sillicon issue with Kaleido itslef. I asked a colleague to test it on his MacOS and he had no issues with Apple M3 Max . I am inclined to consider it to be a Kaleido issue as there have been some reports in the past related to that plotly/Kaleido#129

I will investigate further and provide another update once I know more.

@andrei-ng andrei-ng added the kaleido Issue related to Kaleido dependency label Dec 6, 2024
@andrei-ng andrei-ng changed the title Kaleido doesn't generate the image output Kaleido doesn't generate the image output on MacOS Jan 2, 2025
@alceal
Copy link
Author

alceal commented Jan 3, 2025

Hi @alceal, is the architecture of your Mac by any chance arm?

Yes, it's Apple Silicon M1 Max

@andrei-ng
Copy link
Collaborator

Thank you for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kaleido Issue related to Kaleido dependency
Projects
None yet
Development

No branches or pull requests

4 participants