Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with Ellipses #55

Open
kevin3567 opened this issue Jan 19, 2021 · 1 comment
Open

Dealing with Ellipses #55

kevin3567 opened this issue Jan 19, 2021 · 1 comment

Comments

@kevin3567
Copy link

Hi,

I have noticed that rouge cannot handle strings which contains only ellipses ("......", repeated periods) for either hypothesis or reference. I am wondering why this might be the case, and how do I resolve the problem without replacing ellipses with special characters/substrings?

Thanks

@pltrdy
Copy link
Owner

pltrdy commented Jan 19, 2021

That's correct. In order to correctly calculate ROUGE-L we need to split the text in sentences. Periods are used to detect end of sentence so it's probably the source of the problem.

This could be solved by adding some logic to consider any repetitions of periods as a single end of sentence (i.e. a period after a period should not be considered as an empty sentence). However, I would think that one prefer to consider it as a single token: it does not make sens (to me) to calculate ROUGE over sequences of periods i.e. if both reference and hypothesis has an ellispse of 3 periods should it count as 3 token matches? (I think not).

Long story short: replacing it with special token would be cleaner I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants