Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why aren't the inputs tokenized before used for calculation? #72

Open
liujqian opened this issue Dec 24, 2023 · 0 comments
Open

Why aren't the inputs tokenized before used for calculation? #72

liujqian opened this issue Dec 24, 2023 · 0 comments

Comments

@liujqian
Copy link

It seems that the implementation does not try to properly tokenize the inputs. Punctuations like question marks and commas are not removed, and the token cases are not lowered to maintain consistency. I am wondering, is this on purpose? I am not sure what is done for the official implementation but this tokenization strategy seems very off.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liujqian