Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include select in list of form-tags #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinklepsch
Copy link

via omcljs/om@7c1a337

Not sure if this is correct but given that the other form-tags are specfied where now also select is defined it makes sense to me :)

@martinklepsch
Copy link
Author

Not sure why CI is failing it doesn't seem to be a test but rather some other issue.

@w01fe
Copy link
Member

w01fe commented Jul 7, 2016

Not sure what's up with that. CI seems to be failing on master as well.

This project no longer has an active maintainer, and I'm also not sure if the change is correct :/. If you're not sure it's the right thing, maybe best to work with a fork -- but if you are, I'm happy to merge.

@martinklepsch
Copy link
Author

@w01fe I'm pretty certain it's correct for newer versions of Om (which are backwards compatible in the sense that the om.now namespaces are still around/intact). I'm using it as fork and it's working well with the 1.0.0 alphas (perhaps even below these).

When used with an older version it will probably cause trouble.

@w01fe
Copy link
Member

w01fe commented Jul 7, 2016

Ah makes sense. Thanks for the PR and the explanation! Thinking about it a bit, I don't think it makes sense for me to merge since I'm not going to figure out CI issues or cut a release. I think we should just leave this open for whomever (if anyone) takes over maintenance. Sound reasonable?

@martinklepsch
Copy link
Author

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants