Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:advanced optimizations not removing dead code from Plumbing lib #89

Open
SamHowie opened this issue Mar 24, 2015 · 2 comments
Open

:advanced optimizations not removing dead code from Plumbing lib #89

SamHowie opened this issue Mar 24, 2015 · 2 comments

Comments

@SamHowie
Copy link

I am experiencing an issue where the closure compiler is not eliminating dead code from plumbing.

I have created a simple example of the issue described: https://gist.github.com/SamHowie/aaf8f6b616bb59528ab8

Output file size when requiring plumbing - 145KB
Output file size when manually copy pasting used plumbing functions - 61KB

I am unsure if this is:

  1. a project.clj config error on my part
  2. a closure compiler issue
  3. a cljsbuild issue
  4. a plumbing issue

Has anyone else experienced this?

@atroche
Copy link

atroche commented Jan 4, 2016

@SamHowie did you get to the bottom of this?

@SamHowie
Copy link
Author

SamHowie commented Jan 4, 2016

@atroche Not conclusively.

I arrived at the opinion that is was a clojurescript build issue. From what I read, the Closure Compiler allows one to compile code with multiple entry points. My theory is that the dependent libraries are being used as entry points during compilation.

However, I have not invested enough energy in digging through cljsbuild or the clojurescript compiler to verify this.

It might be interesting to bypass cljsbuild and see if the clojurescript compiler can be configured to optimize as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants