Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Update Templates to Make Partition-Agnostic #37

Open
ferricoxide opened this issue Dec 26, 2018 · 0 comments
Open

Update Templates to Make Partition-Agnostic #37

ferricoxide opened this issue Dec 26, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@ferricoxide
Copy link
Member

Problem Description:

Templates may not be sufficiently portable if ARNs hardcode the :aws: partition-element into them (won't work in specialty-regions like aws-cn). See AWS::Partition pseudo-param documentation.

Expected Behavior:

All templates should work in all AWS partitions

Actual Behavior:

The make_sonarqube_ELBv1.tmplt.json template will fail if not launched into the default/commercial AWS region

Fix recommendation:

Update enumerated template-files to update all "arn:aws:... string-literals to something more like:

            {
              "Fn::Join": [
                ":",
                [
                  "arn",
                  { "Ref": "AWS::Partition"},
                  …,
                  …
                ]
              ]
            }
@ferricoxide ferricoxide added the bug Something isn't working label Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant