Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Investigate security of The AES components #88

Closed
0xJepsen opened this issue Sep 26, 2024 · 3 comments
Closed

feat: Investigate security of The AES components #88

0xJepsen opened this issue Sep 26, 2024 · 3 comments
Assignees
@lonerapier @0xJepsen
Labels
test 🧪 testing

Comments

@0xJepsen
Copy link
Contributor

The may be some security considerations outlined in the crema labs work in this PR crema-labs/aes-circom#7, we should pull the downstream changes and also investigate their constraints carefully.
@0xJepsen 0xJepsen added the test 🧪 testing label Sep 26, 2024
@0xJepsen
Copy link
Contributor Author

Looks like SBOX is not constrained at all https://github.com/pluto/aes-proof/blob/038453186a355d40520608c0d1f7b9140c40ecb5/circuits/aes-gcm/aes/sbox128.circom#L10-L29

@thor314
Copy link
Contributor

thor314 commented Oct 21, 2024

@0xJepsen have you looked into this any further?

@thor314 thor314 mentioned this issue Oct 21, 2024
Closed
4 tasks
@0xJepsen
Copy link
Contributor Author

0xJepsen commented Oct 21, 2024 •
edited
Loading

yes this is done with sambav earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lonerapier lonerapier

@0xJepsen 0xJepsen

Labels
test 🧪 testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thor314 @lonerapier @0xJepsen