Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curious about the code #2

Open
davecramer opened this issue Mar 5, 2021 · 7 comments
Open

Curious about the code #2

davecramer opened this issue Mar 5, 2021 · 7 comments

Comments

@davecramer
Copy link

@elfayoumi

What is the point of doing the difference between the two observations?

Is there somewhere I can find your slides for the talk ?

@elfayoumi
Copy link
Collaborator

Hi davecramer
The example is trying to use the technique to predict the future gain, so from today's past observation, will ASX value increase, decrease, or stay the same?
Financial data are not stationary and as in this example, we could not get more than %39 accuracies, although it is higher than %33 of random guess, it is still close.
So in this example, I am not trying to predict the future value but the change, which is difficult, and the most important.

Sorry, there were no slides, I just used Jupiter notebook to have all the required information.

thanks

@davecramer
Copy link
Author

thanks. I am python challenged so managed to muddle through it. I'm curious that I don't see any large NN libraries including GAM, is there a better way to predict signals ?

@elfayoumi
Copy link
Collaborator

I think the main thing is it increases the size of your data, you convert one dimension array into a two-dimension array, and something like RNN is sufficient, but the idea, is Convolution network has the best performance now, so it is an idea you may like to try, it may work in your case.

@davecramer
Copy link
Author

where does nn come from? I don't see the import ?

@elfayoumi
Copy link
Collaborator

Hi Davecramer
It comes from pytorch
https://pytorch.org/docs/stable/nn.html
fastai imports all relevant imports.

@davecramer
Copy link
Author

interesting. When I try to run it using python3 it fails.

As you can tell I'm not particularly comfortable in python. Much more comfortable in a JVM language

@elfayoumi
Copy link
Collaborator

I need to update the code, this was fadtai version 1, we now version 2, pytorch is 1.8
you can add
from torch import nn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants