Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker has no handler for setMaterial op #339

Closed
isaac-mason opened this issue Jan 25, 2022 · 2 comments
Closed

Worker has no handler for setMaterial op #339

isaac-mason opened this issue Jan 25, 2022 · 2 comments

Comments

@isaac-mason
Copy link
Member

isaac-mason commented Jan 25, 2022

While working on a PR for #327, I noticed that the material atomic prop has an API generated for it, but as far as I can see there is no worker handler for a setMaterial op.

Here's a quick thrown together example - one cube has its material set on creation in it's body props, another tries to set it in an effect.
https://codesandbox.io/s/missing-setmaterial-op-repro-3bhes?file=/src/index.js

Is this just a miss? I take it this API wouldn't be used often.

I'm happy to create a PR to add the missing handler to the worker if it's something we want to add 🙂

@bjornstar
Copy link
Member

If it's something you want to use, go for it.

@isaac-mason
Copy link
Member Author

Sure, created a quick PR for this now: #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants