Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader issue #14

Open
Banck opened this issue Dec 27, 2018 · 2 comments
Open

Loader issue #14

Banck opened this issue Dec 27, 2018 · 2 comments
Labels

Comments

@Banck
Copy link

Banck commented Dec 27, 2018

Hello!
There is an issue with show/hide loader when less than 0.5 seconds have passed with the showLoader() call.
Because you add indicator after 0.5 second in showLoader() method:

UIView.transition(with: self, duration: 0.5, options: .curveEaseOut, animations: {
            self.titleLabel?.alpha = 0.0
            self.imageAlpha = 0.0
        }) { (finished) in
            self.addSubview(self.indicator)
            self.indicator.startAnimating()
        }

And in hideLoader you have this code:

open func hideLoader(){
        guard self.subviews.contains(indicator) == true else {
            return
        }
@pmusolino pmusolino added the bug label Mar 27, 2019
@pmusolino
Copy link
Owner

Hi there. Sorry for the delay and thanks for opening this issue.
I will check it asap.

@darkhorse-coder
Copy link

darkhorse-coder commented Jun 29, 2019

Hi @pmusolino
Thank you for your work.
Have you fixed this delay issue? I think delay issue is there, still... :)
On speed action, the loading is glitched sometimes.
Thank you in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants