Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the point budget sometimes reload the entire tree #44

Open
leops opened this issue Jun 3, 2019 · 1 comment
Open

Changing the point budget sometimes reload the entire tree #44

leops opened this issue Jun 3, 2019 · 1 comment

Comments

@leops
Copy link
Contributor

leops commented Jun 3, 2019

I don't have reliable repro steps but it seems to happen frequently with large point clouds (~20 million points) when lowering the pointBudget after the point cloud has been loaded. By stepping through the algorithm with a debugger it looks like the LRU cache can choose to evict the root node of the tree (node.name === "r"), which will destroy the entire rendering structure prompting a complete reload over the next few frames.

@leops
Copy link
Contributor Author

leops commented Nov 6, 2019

If I remember correctly at the time I was trying to implement an adaptive point budget by timing the duration of the three.js render function over a few frames and dynamically increasing and decreasing the point budget to keep framerate around 60 fps. So to answer your question the exact way I'm changing the point budget is by setting the pointBudget property of the instance of Potree in a useEffect hook of the React app that contains my three.js instance, not sure if that's really helpful though ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant