Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phong shading is broken #47

Open
rhuitl opened this issue Sep 24, 2019 · 2 comments
Open

Phong shading is broken #47

rhuitl opened this issue Sep 24, 2019 · 2 comments

Comments

@rhuitl
Copy link
Contributor

rhuitl commented Sep 24, 2019

The fragment shader does not compile when PointColorType is PHONG:

ERROR: 0:212: 'emissive' : undeclared identifier
ERROR: 0:212: 'ambientLightColor' : undeclared identifier
ERROR: 0:212: 'ambient' : undeclared identifier

It looks like these variables are not at all defined, should probably be uniforms.

gl_FragColor.xyz = gl_FragColor.xyz * ( emissive + totalDiffuse + ambientLightColor * ambient ) + totalSpecular;

The material does not define any of these.

@hccampos
Copy link
Collaborator

Would you like to make a PR for this? We don't use this feature and at the moment have no time for maintaining this lib.

@rhuitl
Copy link
Contributor Author

rhuitl commented Sep 24, 2019

It's not high priority for us either, I was just curious to see it in action. I might try to get it working when I find the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants