Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for formats other than Potree cloud.js? #63

Open
glostis opened this issue Apr 6, 2020 · 5 comments
Open

Support for formats other than Potree cloud.js? #63

glostis opened this issue Apr 6, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@glostis
Copy link

glostis commented Apr 6, 2020

Hi,

Thanks a lot for this library!

I was wondering if you had any plans to support formats other than Potree's cloud.js/octree?

Support for the EPT format, among others was added to potree.js (see https://github.com/potree/potree/tree/develop/src/loader) and I would much prefer to use this format than the Potree octree format for which I need to use the old and inconvenient PotreeConverter tool.

To put it more broadly: what input formats does this library currently support, other than the cloud.js/octree generated with PotreeConverter?

@fahadm
Copy link
Collaborator

fahadm commented Apr 11, 2020

Right now we do primarily support potree octree format. But I'll take a look into if the ept format offers significant improvements over the potree octree format. We may yet add support for it in the future.

@fahadm fahadm self-assigned this Apr 11, 2020
@fahadm fahadm added the SPIKE label Apr 11, 2020
@glostis
Copy link
Author

glostis commented Apr 24, 2020

🙏 Thanks for looking into this!

From my point of view there are several advantages of EPT vs Potree octree:

  • PotreeConverter is not actively maintained and has several open issues/PRs for critical issues (e.g.: Fix segfault and nondeterminism in command line argument parsing. potree/PotreeConverter#335), while the Entwine project looks more active, is documented, etc.
  • Entwine integrates nicely within the PDAL ecosystem, namely you can convert from EPT to another common LiDAR format easily (see example) whereas this cannot be done with the Potree octree format (i.e. once you convert your data to a Potree octree, you cannot easily convert back to another format)
  • The EPT format stores its nodes in LAZ format by default (this can also be done with PotreeConverter, but is not the default) and seems to generate fewer nodes than PotreeConverter in general. (I'm not 100% certain on this last point, so to be taken with caution)

@fahadm
Copy link
Collaborator

fahadm commented Apr 26, 2020

Sounds good to me, the only thing that I see is that the base EPT code is LGPL while we are MIT.
However, I will be porting/refactoring code from the Potree repo so that should be MIT too.

I'll try adding support, but expect it to take a few weeks to months depending on if something higher priority comes in.

@fahadm fahadm added enhancement New feature or request PR Welcome labels Apr 26, 2020
@glostis
Copy link
Author

glostis commented Apr 27, 2020

Thank you very much, that would be great!

I would have liked to be able to contribute to this enhancement, but unfortunately, I know nothing about Typescript/JS...

@fahadm fahadm added this to the 0.3.0 milestone Sep 28, 2020
@mkarklins
Copy link

Anyone has taken a stab at this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants