Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes Feature for PhotoInput and Photo components #74

Open
charliepnnl opened this issue Jun 17, 2023 · 3 comments · May be fixed by #253
Open

Notes Feature for PhotoInput and Photo components #74

charliepnnl opened this issue Jun 17, 2023 · 3 comments · May be fixed by #253
Assignees

Comments

@charliepnnl
Copy link
Contributor

Allow the user to add notes associated with each photo in PhotoInput. The notes should be a TextInput that appears underneath the photo. If the notes text is non-empty, it should be shown under the corresponding photo in the Photo component.

This will require a scheme by which data is stored in the document that is associated with an attachment. Consider adding a top-level attachments_metadata_ field to the document. attachements_metadata_ is an object that maps attachment ids to corresponding metadata object in which we include a notes field. Functionality will need to be added to the Store to make this data available through Context and to allow this data to be upserted.

@lindsayJohnstonPnnl
Copy link
Collaborator

This new data will go in the data_: field. For this example:

image

There should be one "existing_duct_photo_note" field for all of the "existing_duct_photo"s.

@lindsayJohnstonPnnl
Copy link
Collaborator

lindsayJohnstonPnnl commented Dec 17, 2024

Make sure <TextInput/> displays correctly in all browsers

@lindsayJohnstonPnnl
Copy link
Collaborator

lindsayJohnstonPnnl commented Dec 18, 2024

Safari:
image

Chrome:
image

Firefox:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants