Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide user-input validation #52

Closed
lymereJ opened this issue Dec 1, 2022 · 2 comments
Closed

Provide user-input validation #52

lymereJ opened this issue Dec 1, 2022 · 2 comments
Assignees
@lymereJ
Labels
enhancement New feature or request

Comments

@lymereJ
Copy link
Collaborator

lymereJ commented Dec 1, 2022

As per a discussion with @jugonzal07, Copper should provide some degree of user-input validation.

Examples:

  • Do not attempt to run if the input reference capacity of a chiller is 0 or negative
  • Do not attempt to run if the input targeted full load efficiency or part load efficiency of a chiller is 0 or negative
@lymereJ lymereJ self-assigned this Dec 1, 2022
@lymereJ lymereJ added the enhancement New feature or request label Dec 1, 2022
@ChristensenCode
Copy link
Contributor

I added a json schema so I'll make it it's own branch and submit a pull request with that in the next week or so.

Schemas are so nice for input validation.

@lymereJ lymereJ mentioned this issue Oct 27, 2023
Merged
@lymereJ
Copy link
Collaborator Author

lymereJ commented Nov 1, 2024

Addressed in #72.

@lymereJ lymereJ closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lymereJ lymereJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lymereJ @ChristensenCode