-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: create Azure AD app registration #1962
Comments
@pnp/cli-for-microsoft-365-maintainers I'd love your feedback on the above spec |
Hi @waldekmastykarz, Instead of providing a "secretname" I would just provide a flag --secret. I would also provide an option to generate an upload a certificate with a flag. Cheers, |
The name
I've been thinking about this too, but to me an option named As for the cert: would you allow folks to upload their own cert or would you rather have them indicate that they want a cert and we then create one on the fly for them? |
How about
As above, how about
As above, how about
When we say permissions, do we mean scopes?
I would consider these options as advanced and would possibly drop them from the initial command, are these options commonly used?
I think we should implement the creation of the certificate for the user. |
We don't use
See the remark above
For the secret we have to specify name, so it's not enough to just say
Yes
In Teams development they are 🙂
👍 |
Makes sense, lets go with that 🙂
I think setting a default name would be my preferred option,
I see, happy to go with your suggestion then as I've not done much Teams development, hence why I've not used them 😄 |
Additional thing I was thinking is, that as long as they're not required, there is no problem with introducing them, if there is a chance they'd be helpful. Updated spec. Is it ready to go now? |
Spec is ready but just to be picky, shouldn't it be |
Well, I can't argue with that 😁 |
Usage
aad app add [options]
Description
Creates Azure AD app registration
Options
-n, --name <name>
--multitenant
-r, --redirectUris [redirectUris]
-p, --platform [platform]
spa
,web
,publicClient
--implicitFlow
-s, --withSecret
Default
--apisDelegated [apisDelegated]
--apisApplication [apisApplication]
-u, --uri [uri]
--scopeName [scopeName]
uri
to be specified--scopeConsentBy [scopeConsentBy]
admins
,adminsAndUsers
. Defaultadmins
--scopeAdminConsentDisplayName [scopeAdminConsentDisplayName]
--scopeAdminConsentDescription [scopeAdminConsentDescription]
Additional Information
After creating the app registration, the command sets the current user as its owner.
The command returns app's ID, ObjectID and the generated secret if one was created.
This command is similar to
az ad app create
and is meant to simplify the process of creating app registrations with supporting the most common scenarios in an opinionated way.The text was updated successfully, but these errors were encountered: