-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dynamic Form] Update Form crashes on loading, if an item has TaxonomyFieldTypeMulti field. [3.16.1] !!! #1733
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Hi @bva999, I tried to repro without success but maybe I'm missing context info. Can you give me details about the Taxonomy field you're refering to, such as column settings, term structure (parent / children),...? In my case I tried with following config (sorry it's in french): Edit: this is the content of my |
Hi @michaelmaillot .
Terms Structure: |
Ok I can repro the issue. If I'm not mistaken, we shouldn't end up in the last else block (in the screen) as this one is reached for a new item. We should be inside the first if block that parses the Taxonomy array values. And neither you and me have a property called "results" in the @IRRDC following what you've stated here, I would like to get more info regarding your use case (list / library, field properties, site context,...), if you don't mind. I want to understand what are we missing here, even if I realized that I didn't push far enough tests when merging the PR #1718... |
@michaelmaillot Thanks for looking into this. I had to search for a while and noticed that back in August I got my information from my web part stopping on the error in the compiled code. |
I created a new fix (to fix the fix): #1736 |
@michaelmaillot I have mixed results. In my existing web part solution I'm back to my original problem, where in the compiled code item[field.InternalName] contains a sub-property "results" which has to be iterated. My original fix worked for that in the compiled code from the npm package. |
Thanks for this feedback. This is strange indeed and I couldn't reproduce the Are you suggesting that @pnp/sp 3.x returns data in a different format than 2.x version? |
That's what I thought first but I haven't been able to reproduce the error in the newly created web part and have by now copied nearly all the code and all the settings from the one that throws the error (and produces the additional "results" property). |
Hi @michaelmaillot. It's works for me. |
@IRRDC did you figure out the |
No, it's very frustrating. I've spent days on it and created new working solutions and then suddenly the dynamic form failed to load again because the data was in "results" again. I thought I had a issue free version a few hours ago but it fails when testing on a different SharePoint tenent. I will create a new solution again tomorrow and see if it fails from the start on that tenent. |
I started again with a new solution and a HelloWorld web part with just the dynamic form and it can display list A from site X on tenant 1 and list B on site Y on tenant 1 and list C on tenant 2. |
A possible fix for pnp#1733 when the data gets returned in a non-standard way.
I created another fix and copied the compiled code into my solution where it is now able to load the form for all sites and lists. #1744 |
Any thoughts? |
@joelfmrodrigues Why did you close the bug without comment when there is an open pull request to fix existing issues? |
@IRRDC thanks for the heads up, I may have mistaken this with another issue from a different PR from @michaelmaillot |
During a quick test this morning I couldn't reproduce the issue with the new version but I could not perform all test scenarios due to this new issue in the dynamic form #1758 |
Hi @IRRDC this issue has been closed because its original PR (which was a rollback from has been released in 3.16.1) has been merged and closed, then released in minor version. Your PR is linked to a global behavior for which we didn't figure out the root cause, thus not linked to this issue in particular. Before addressing this one, we need to understand what causes this I'll open a new issue. |
Done #1759 |
Category
[ ] Enhancement
[x ] Bug
[ ] Question
Version
Please specify what version of the library you are using: [3.16.1]
Observed Behavior
If an item has a TaxonomyFieldTypeMulti field , the Dynamic Form crashes on loading. And get next error:
It assumes that value should be a string , but it is an Array of objects:
The text was updated successfully, but these errors were encountered: