Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker: what to do with amDesignator and pmDesignator? #348

Closed
robert-lindstrom opened this issue Jul 29, 2019 · 3 comments
Closed

Comments

@robert-lindstrom
Copy link
Contributor

Category

[ ] Enhancement

[ ] Bug

[x] Question

Version

Please specify what version of the library you are using: [latest]

Expected / Desired Behavior / Question

Setting the amDesignator and pmDesignator strings as shown below has no effect on the DateTimePicker component.

<DateTimePicker strings={{ amDesignator: 'newAM', pmDesignator: 'newPM', ...  }} ... />

This has never worked and is not easily fixed (and probably not needed).

What should be done about this?

Is it safe to just remove these properties since it has never worked?

Do we have a way of deprecating this?

@ghost
Copy link

ghost commented Jul 29, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 29, 2019
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 29, 2019

I would just remove them.
I don't think these properties will be used by someone.
Or we can fix the control to use them as well :)

@joelfmrodrigues
Copy link
Collaborator

Closing as answered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants