Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug report: Grant API permissions action works but presents error #264

Open
Adam-it opened this issue Jun 30, 2024 · 4 comments
Open
Assignees
Labels
🐞 bug Something isn't working πŸ‘¨β€πŸ’» CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 hacktoberfest πŸ‘¨β€πŸ’»work in progress I am working on it
Milestone

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Jun 30, 2024

⭐ Priority

(Medium)😒 I'm annoyed but I'll live

πŸ“ Describe the bug

the grant API permission action seems to be failing with some cryptic error message
image

even though it seems to work properly
image

I did some investigation and it seems CLI for Microsoft 365 is failing when running m365 spfx project permissions grant

image

So in order to fix this issue we should first open a bug in CLI for Microsoft 365 and have it fixed there as well. After it will get fixed in that repo we should align our commonjs CLI copy and restest

πŸ‘£ Steps To Reproduce

just run Grant API permissions on any SPFx project

πŸ“œ Expected behavior

should grant permissions, this works, but shouldn't present any error message

πŸ“· Screenshots

added above

❓SharePoint Framework Toolkit version

3.3.0

❓Node.js version

18.18.2

πŸ€” Additional context

No response

@Adam-it Adam-it added 🐞 bug Something isn't working πŸ™ help wanted Open for contributors πŸ‘¨β€πŸ’» CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 labels Jun 30, 2024
@Saurabh7019
Copy link
Contributor

Let me look into this issue. Also, I will create a bug report in the CLI repo if one doesn't already exist.

@Adam-it Adam-it added πŸ‘¨β€πŸ’»work in progress I am working on it and removed πŸ™ help wanted Open for contributors labels Jul 3, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 3, 2024

Let me look into this issue. Also, I will create a bug report in the CLI repo if one doesn't already exist.

All yours.
No the bug on CLI repo still doesn't exist. I didn't have time to add it yet

@Saurabh7019
Copy link
Contributor

still doesn't exist

actually, it does. pnp/cli-microsoft365#5889

@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 3, 2024

still doesn't exist

actually, it does. pnp/cli-microsoft365#5889

AAA awesome, I didn't notice that one. Sorry it is just to much for me sometimes πŸ˜‰. Now let's resolve it on CLI side and then we may update the CJS version of CLI and it should 'just' work here πŸ˜…

@Adam-it Adam-it added this to the v3.X milestone Jul 28, 2024
@Adam-it Adam-it modified the milestones: v3.X, v4.X Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working πŸ‘¨β€πŸ’» CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 hacktoberfest πŸ‘¨β€πŸ’»work in progress I am working on it
Projects
None yet
Development

No branches or pull requests

2 participants